Path: csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod From: John Stultz Newsgroups: linux.kernel Subject: [RFC][PATCH 2/5 v3] drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() Date: Mon, 12 Dec 2016 22:10:02 +0100 Message-ID: References: X-Original-To: lkml Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EWT1/2E/Jy2+pBKgM/aaeeaZVzlNMxLNL5ypvQtBCwk=; b=esmlUkfBg7zQ+Tpq/x8H4o1ei4Bzjp/waoVv0h5QMZ7OnO92xFQ8Dng/v2NwRpYKPI Lwl2wJ62cJow2bcobUua67QMs5U9ANh6sxEPtJYtb7XwJ/Wb0u1+4PmXjJCyuWBN6cfu 1X+tnNmEHUZyDnae428mVpzERDIgriZohDUl0= X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EWT1/2E/Jy2+pBKgM/aaeeaZVzlNMxLNL5ypvQtBCwk=; b=iHx+6KK6k3Jrf/lT2XSOtb+CiPiekAjrRMeHGRPJX3lDBZzoXbcUgJBKDwvy8CLWAu JMLPtShUBpjMaWufG1crbpnkuWd5lNvnYKn3qkkzhNh1s5IETqKrqiehPD5gZEQjUawI OqVpgtExb/pkd1TS3sSeHbCNl5xZ4sdDdAKp5L+F01+r3zJv1sI+v1Hnydfqz+sSTYYl JybFAReZBRp9j9uIhNPB7yOBjQbs5MYx3DyJQ5a0anqDTS03iAlbYHXGstff2VzXdp/T LWl9yDuUqVJrLHNuG8JvnYvkZVs07EJ9odJhU3bwC0XC7vMnNf9ZbpSAo/OavilFafn8 AO9Q== X-Gm-Message-State: AKaTC00B3Uxvv41cdh0uhL2bXRhVB26gSyy78pBc7RSL5rGuXBor4sYQjsj2N6fqUCC65i4J X-Received: by 10.99.171.65 with SMTP id k1mr170401354pgp.87.1481576447340; Mon, 12 Dec 2016 13:00:47 -0800 (PST) X-Mailer: git-send-email 2.7.4 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 54 Organization: linux.* mail to news gateway X-Original-Cc: John Stultz , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , Laurent Pinchart , dri-devel@lists.freedesktop.org X-Original-Date: Mon, 12 Dec 2016 13:00:38 -0800 X-Original-Message-ID: <1481576441-23529-3-git-send-email-john.stultz@linaro.org> X-Original-References: <1481576441-23529-1-git-send-email-john.stultz@linaro.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1540660 In chasing down a previous issue with EDID probing from calling drm_helper_hpd_irq_event() from irq context, Laurent noticed that the DRM documentation suggests that drm_kms_helper_hotplug_event() should be used instead. Thus this patch replaces drm_helper_hpd_irq_event() with drm_kms_helper_hotplug_event(), which requires we update the connector.status entry and only call _hotplug_event() when the status changes. Cc: David Airlie Cc: Archit Taneja Cc: Wolfram Sang Cc: Lars-Peter Clausen Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- v3: Update connector.status value and only call __hotplug_event() when that status changes, as suggested by Laurent. --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 4fcea44..d93d66f 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -405,8 +405,22 @@ static bool adv7511_hpd(struct adv7511 *adv7511) static void adv7511_hpd_work(struct work_struct *work) { struct adv7511 *adv7511 = container_of(work, struct adv7511, hpd_work); + enum drm_connector_status status; + unsigned int val; + int ret; + + ret = regmap_read(adv7511->regmap, ADV7511_REG_STATUS, &val); + if (ret < 0) + status = connector_status_disconnected; + else if (val & ADV7511_STATUS_HPD) + status = connector_status_connected; + else + status = connector_status_disconnected; + + if (adv7511->connector.status != status) + drm_kms_helper_hotplug_event(adv7511->connector.dev); - drm_helper_hpd_irq_event(adv7511->connector.dev); + adv7511->connector.status = status; } static int adv7511_irq_process(struct adv7511 *adv7511, bool process_hpd) -- 2.7.4