Path: csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod From: Jason Wang Newsgroups: linux.kernel Subject: Re: [PATCH 02/10] drm/virtio: fix endianness in primary_plane_update Date: Wed, 07 Dec 2016 05:20:01 +0100 Message-ID: References: X-Original-To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 07 Dec 2016 04:13:19 +0000 (UTC) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 30 Organization: linux.* mail to news gateway X-Original-Cc: David Airlie , Gerd Hoffmann , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org X-Original-Date: Wed, 7 Dec 2016 12:13:13 +0800 X-Original-Message-ID: X-Original-References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-3-git-send-email-mst@redhat.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1537474 On 2016年12月06日 23:40, Michael S. Tsirkin wrote: > virtio_gpu_cmd_transfer_to_host_2d expects x and y > parameters in LE, but virtio_gpu_primary_plane_update > passes in the CPU format instead. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jason Wang > > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c > index ba28c0f..1fda965 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c > @@ -88,8 +88,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane *plane, > (vgdev, handle, 0, > cpu_to_le32(plane->state->src_w >> 16), > cpu_to_le32(plane->state->src_h >> 16), > - plane->state->src_x >> 16, > - plane->state->src_y >> 16, NULL); > + cpu_to_le32(plane->state->src_x >> 16), > + cpu_to_le32(plane->state->src_y >> 16), NULL); > } > } else { > handle = 0;