Path: csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod From: Rui Wang Newsgroups: linux.kernel Subject: [PATCH v3 3/5] x86/ioapic: Fix setup_res() failing to get resource Date: Wed, 10 Aug 2016 06:20:01 +0200 Message-ID: References: X-Extloop1: 1 X-Ironport-Av: E=Sophos;i="5.28,497,1464678000"; d="scan'208";a="1038382009" X-Mailer: git-send-email 1.7.5.4 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 24 Organization: linux.* mail to news gateway X-Original-Cc: tony.luck@intel.com, bhelgaas@google.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rui.y.wang@intel.com X-Original-Date: Wed, 10 Aug 2016 12:01:56 +0800 X-Original-Message-ID: <1470801718-29004-4-git-send-email-rui.y.wang@intel.com> X-Original-References: <1470801718-29004-1-git-send-email-rui.y.wang@intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1459282 acpi_dev_filter_resource_type() returns 0 on success, and 1 on failure. A return value of zero means there's a matching resource, so we should continue within setup_res() to get the resource. Signed-off-by: Rui Wang --- drivers/acpi/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c index 2449377..8ab6d42 100644 --- a/drivers/acpi/ioapic.c +++ b/drivers/acpi/ioapic.c @@ -46,7 +46,7 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data) struct resource_win win; res->flags = 0; - if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM) == 0) + if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM)) return AE_OK; if (!acpi_dev_resource_memory(acpi_res, res)) { -- 1.8.3.1