Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: Raanan Avargil Newsgroups: linux.kernel Subject: Re: [Intel-wired-lan] e1000e: PHY cann't be initialized correctly on some I218 controllers Date: Tue, 09 Aug 2016 17:20:01 +0200 Message-ID: References: X-Original-To: Denis Turischev , intel-wired-lan@lists.osuosl.org, "Brown, Aaron F" , Jeff Kirsher X-Extloop1: 1 X-Ironport-Av: E=Sophos;i="5.28,495,1464678000"; d="scan'208";a="1011237373" User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: 8BIT Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 34 Organization: linux.* mail to news gateway X-Original-Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Tue, 9 Aug 2016 18:10:53 +0300 X-Original-Message-ID: X-Original-References: <579F407E.9090602@compulab.co.il> <1e8f37ec-eda4-eb2d-64d2-e96a7aa71902@intel.com> <57A6F7A9.1030401@compulab.co.il> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1458840 On 8/7/2016 11:56, Denis Turischev wrote: > Hi Raanan, > > On 08/04/2016 07:18 PM, Raanan Avargil wrote: >> It is hard to determine what is exactly the problem here and what causes the -3 error, but this is not the place to perform hw reset and retry to init the phy. > I agree that may be this is not the correct place for hw reset, can you advice about another solution? > > It works, not only for me, for example it helps here: > http://www.linux.org.ru/forum/linux-hardware/10268216 > > Another fact that Windows drivers work fine with the same hw. > > Denis > Hi Denis, More suitable place to retry init the device would be in probe function. However, we haven't seen initialization issues like this on i218. Adding Aaron. @Aaron - have you seen initialization errors on i218 devices? Raanan --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.