Path: csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Baole Ni Newsgroups: linux.kernel Subject: [PATCH 0386/1285] Replace numeric parameter like 0444 with macro Date: Tue, 02 Aug 2016 19:40:03 +0200 Message-ID: X-Extloop1: 1 X-Ironport-Av: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858102257" X-Mailer: git-send-email 2.9.2 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 27 Organization: linux.* mail to news gateway X-Original-Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, standby24x7@gmail.com X-Original-Date: Tue, 2 Aug 2016 19:06:40 +0800 X-Original-Message-ID: <20160802110640.7509-1-baolex.ni@intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1455174 I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/dvb-frontends/stv090x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/stv090x.c b/drivers/media/dvb-frontends/stv090x.c index 25bdf6e..77f7c99 100644 --- a/drivers/media/dvb-frontends/stv090x.c +++ b/drivers/media/dvb-frontends/stv090x.c @@ -39,7 +39,7 @@ #define MAX_XFER_SIZE 64 static unsigned int verbose; -module_param(verbose, int, 0644); +module_param(verbose, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* internal params node */ struct stv090x_dev { -- 2.9.2