Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Baole Ni Newsgroups: linux.kernel Subject: [PATCH 0642/1285] Replace numeric parameter like 0444 with macro Date: Tue, 02 Aug 2016 14:20:02 +0200 Message-ID: X-Extloop1: 1 X-Ironport-Av: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1006949954" X-Mailer: git-send-email 2.9.2 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 32 Organization: linux.* mail to news gateway X-Original-Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com X-Original-Date: Tue, 2 Aug 2016 19:32:24 +0800 X-Original-Message-ID: <20160802113224.24837-1-baolex.ni@intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1454017 I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/usb/pwc/pwc-if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c index 18aed5d..cf8326c 100644 --- a/drivers/media/usb/pwc/pwc-if.c +++ b/drivers/media/usb/pwc/pwc-if.c @@ -1164,10 +1164,10 @@ static void usb_pwc_disconnect(struct usb_interface *intf) static unsigned int leds_nargs; #ifdef CONFIG_USB_PWC_DEBUG -module_param_named(trace, pwc_trace, int, 0644); +module_param_named(trace, pwc_trace, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #endif -module_param(power_save, int, 0644); -module_param_array(leds, int, &leds_nargs, 0444); +module_param(power_save, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_array(leds, int, &leds_nargs, S_IRUSR | S_IRGRP | S_IROTH); #ifdef CONFIG_USB_PWC_DEBUG MODULE_PARM_DESC(trace, "For debugging purposes"); -- 2.9.2