Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Baole Ni Newsgroups: linux.kernel Subject: [PATCH 0638/1285] Replace numeric parameter like 0444 with macro Date: Tue, 02 Aug 2016 14:20:02 +0200 Message-ID: X-Extloop1: 1 X-Ironport-Av: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="858121331" X-Mailer: git-send-email 2.9.2 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 27 Organization: linux.* mail to news gateway X-Original-Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com X-Original-Date: Tue, 2 Aug 2016 19:32:06 +0800 X-Original-Message-ID: <20160802113206.24573-1-baolex.ni@intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1454023 I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/usb/msi2500/msi2500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c index 2d33033..bf2dd49 100644 --- a/drivers/media/usb/msi2500/msi2500.c +++ b/drivers/media/usb/msi2500/msi2500.c @@ -33,7 +33,7 @@ #include static bool msi2500_emulated_fmt; -module_param_named(emulated_formats, msi2500_emulated_fmt, bool, 0644); +module_param_named(emulated_formats, msi2500_emulated_fmt, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(emulated_formats, "enable emulated formats (disappears in future)"); /* -- 2.9.2