Path: csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod From: Matthew Leach Newsgroups: linux.kernel Subject: Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Date: Wed, 11 May 2016 20:30:02 +0200 Message-ID: References: X-Greylist: delayed 463 seconds by postgrey-1.27 at vger.kernel.org; Wed, 11 May 2016 14:26:18 EDT User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 38 Organization: linux.* mail to news gateway X-Original-Cc: Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz X-Original-Date: Wed, 11 May 2016 19:18:31 +0100 X-Original-Message-ID: <87y47gwj9k.fsf@mattleach.net> X-Original-References: <1462950412-16681-1-git-send-email-k.kozlowski@samsung.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1399407 Hi Krzysztof, Sorry for not acting on the feedback sooner - I lost the email in my Inbox! I've tested the patch on my Origen board and it works fine. One small comment in-line. Krzysztof Kozlowski writes: > From: Matthew Leach > > Enable the Origen's usb phy and ohci devices in the device tree. Also > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so > the AX88760 hub is powered. > > Signed-off-by: Matthew Leach > [k.kozlowski: Extend nodes by label notation instead of path] > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts > index 8bca699b7f20..4c59bdb0e6f3 100644 > --- a/arch/arm/boot/dts/exynos4412-origen.dts > +++ b/arch/arm/boot/dts/exynos4412-origen.dts > @@ -77,12 +77,29 @@ > clock-frequency = <24000000>; > }; > }; > + I think we could loose this line break? Thanks, -- Matt