Path: csiph.com!news.redatomik.org!newsfeed.xs4all.nl!newsfeed8.news.xs4all.nl!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Arnd Bergmann Newsgroups: linux.kernel Subject: [PATCH, RESEND] serial-uartlite: un-constify uartlite_be/uartlite_le Date: Sun, 17 Apr 2016 02:20:02 +0200 Message-ID: X-Original-To: Peter Korsgaard , Greg Kroah-Hartman X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:1aOOKisZRUEDS81Ov6bcRF5E5MEl15gis1nQBqukvysiP71QhQt HHht+nYNgeEfivGmHr3638bwv+VgqjN8XqAyDwlkQYylyhVueaDlGfCECg4RtnF/YePTBNr 0rjxnp5sbQG9yXSumWMGj1UrnzCu7eH7sUWy/eGv+PNWNq5oga07hzcfmRG1moHjPsgtClr uz8XOuP08TBGbkvoDa9Sg== X-Ui-Out-Filterresults: notjunk:1;V01:K0:prOP5agKDtc=:iLWgurqk7SaD2oIirDgL+m DH92lpWGf64ea5kBJjblyIuwlaMliPuS+V3G3DJOynTTz8YHPTd24yAHjCAkhiG4exd3gM5Us 5LgiJeszewkut04gV3elbRbQpf29EPmUMTUwIEcRfE9vLfDpNwyVwoRTjmP6BswXGVYfSe/zF 9J9WWfk1sb+Q5jwdSXQXVsbATmTCaGa3564tfe+NgNyUyg90bhr9hayrx+2VrQ2U1nPAM6Z2G 3tNpOi8pAQXrzl649bYiNxLHwX9QRK6M6KC7p5J2hzB9beNb3DZwJ5jUgrnqGnXKM6VGaP4uv dh7aB205LxkAAGkEp1UyWSzV61l0jE84deGnO3GtR0zBTn4l5qoTKMQiGSGG1G+LlY7KGlFda ENK84fXiissjYa0xyD8W5q7hW3NASfuXksUIUckCI5mAfS64Hs7/U0CrAdOgVIfwq7UrLck8N On16u9QFMw0SwJUZfhhSW2F8nu3ClEBdUkzYEtdA1iM4csVoB9V4uUrpm7YgqNGY04JKem1cj Sb0YvWt03+G0GyY+KDXgtkhZVBx2J91wVnZCIX33kXcnxX52jyY1sNGZlUNevF2VbODiF/WUH g/fM9VI0oosFpshBUQZtALFQc1j4fqClnRUlQ07iNlr+05C5rv+sBnbOErOXXUheJiB4ZAv3/ Nkaj2DUd6xhBU0Npi/s2HRcULPm9Bb605OxaMJ/7BZwd+7ujAabTaIZecLe0F17/+5FY= Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 51 Organization: linux.* mail to news gateway X-Original-Cc: Arnd Bergmann , Jiri Slaby , Maarten Brock , Rich Felker , Michal Simek , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Sun, 17 Apr 2016 02:12:47 +0200 X-Original-Message-ID: <1460851985-1280235-1-git-send-email-arnd@arndb.de> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1380662 The patch to make uartlite_be/uartlite_le const was well-intended but caused a new build warning: tty/serial/uartlite.c: In function 'ulite_request_port': tty/serial/uartlite.c:348:21: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] tty/serial/uartlite.c:354:22: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] It would be nice to allow passing const pointers through port->private_data, but that would be way more work, so this reverts part of the original commit for now. A possible alternative might be to pass a structure in the private_data that contains a const pointer to the operations, which introduces a little extra overhead, or we could just add a cast to a non-const pointer, I'll leave that to the maintainer. Signed-off-by: Arnd Bergmann Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le") --- drivers/tty/serial/uartlite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) I sent this patch on March 10, but it never made it in. Greg, could you apply the patch as a bugfix for 4.6? The warning is annoying as it shows up in several defconfig builds and allmodconfig. diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c index c9fdfc8bf47f..1474c5755140 100644 --- a/drivers/tty/serial/uartlite.c +++ b/drivers/tty/serial/uartlite.c @@ -72,7 +72,7 @@ static void uartlite_outbe32(u32 val, void __iomem *addr) iowrite32be(val, addr); } -static const struct uartlite_reg_ops uartlite_be = { +static struct uartlite_reg_ops uartlite_be = { .in = uartlite_inbe32, .out = uartlite_outbe32, }; @@ -87,7 +87,7 @@ static void uartlite_outle32(u32 val, void __iomem *addr) iowrite32(val, addr); } -static const struct uartlite_reg_ops uartlite_le = { +static struct uartlite_reg_ops uartlite_le = { .in = uartlite_inle32, .out = uartlite_outle32, }; -- 2.7.0