Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Marc Zyngier Newsgroups: linux.kernel Subject: Re: [PATCH v4] irqchip/gicv3-its: Don't allow devices whose ID is outside range Date: Thu, 17 Mar 2016 16:40:02 +0100 Message-ID: References: Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 25 X-Original-Cc: Thomas Gleixner , Jason Cooper , Vikram Sethi , Eric Auger X-Original-Date: Thu, 17 Mar 2016 15:34:29 +0000 X-Original-Message-ID: <56EACE85.4090603@arm.com> X-Original-References: <1458227925-21952-1-git-send-email-shankerd@codeaurora.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1359959 On 17/03/16 15:18, Shanker Donthineni wrote: > We are not checking whether the requested device identifier fits into > the device table memory or not. The function its_create_device() > assumes that enough memory has been allocated for whole DevID space > (reported by ITS_TYPER.Devbits) during the ITS probe() and continues > to initialize ITS hardware. > > This assumption is not perfect, sometimes we reduce memory size either > because of its size crossing MAX_ORDER-1 or BASERn max size limit. The > MAPD command fails if 'Device ID' is outside of device table range. > > Add a simple validation check to avoid MAPD failures since we are > not handling ITS command errors. This change also helps to return an > error -ENOMEM instead of success to caller. > > Signed-off-by: Shanker Donthineni Is there any difference between this patch and the one you posted on March 10th? Thanks, M. -- Jazz is not dead. It just smells funny...