Path: csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod From: Rob Herring Newsgroups: linux.kernel Subject: Re: [PATCH V1] documentation: da9052: Update regulator bindings names to match DA9052/53 DTS expectations Date: Wed, 27 Jul 2016 17:00:01 +0200 Message-ID: References: X-Original-To: Steve Twiss X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l3wWJT0HRWN0WeXnnNy0JNTAJUX+KTI+jA6ZbrK0MEs=; b=WnKrGX5+hEgMZY2Thw0FoUc8c2sgYcYULV1Yj/tFuBjpmggM0+SrEr9G3C81Wkqc7g Pfce7G5Vb91PNCHII74RJuPOzxMIQatT3qzic8nZ4XtBqsVw9gtoP+8liayvH4kIaV3q 9BBhCV+HuKJB9d0vWfWblBtIV2IiixU0jRbax53K/36jmT6ykdL3SLvAtiReyiddf6HO INef/DNzZZZVOJwGjwm2OIS8OWvEBQQWLRqwmVdSC8IiXD7Gz2MScC9d8OUL6J2RIJKt pKdoDmWnO6TzD0z8WiyyhZsbuIADX8D3HbFe8l614cgM871m0sJ/re3Kofvpa/MvGxxX lHvA== X-Gm-Message-State: AEkoouvoBlYk2S6juMfr9KEGRaL/JKSpyLB/4xKqefTq0/BATGEnFlp0OPXi6MUwHmJ1Zw== X-Received: by 10.202.239.69 with SMTP id n66mr17717904oih.108.1469631112835; Wed, 27 Jul 2016 07:51:52 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 65 Organization: linux.* mail to news gateway X-Original-Cc: DEVICETREE , DTKERNEL , LINUXKERNEL , Mark Rutland , Support Opensource , Ying-Chun Liu X-Original-Date: Wed, 27 Jul 2016 09:51:51 -0500 X-Original-Message-ID: <20160727145151.GA20193@rob-hp-laptop> X-Original-References: <20160725152349.A692D3FACB@swsrvapps-01.diasemi.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1451325 On Mon, Jul 25, 2016 at 04:20:54PM +0100, Steve Twiss wrote: > From: Steve Twiss > > Hi Mark, Drop this from the commit msg. > > Buck and LDO binding name changes. > > The binding names for the regulators have been changed to match the current > expectation from existing device tree source files. > > This fix rectifies the disparity between what currently exists in some > .dts[i] board files and what is listed in this binding document. This > change re-aligns those differences and also brings the binding document > in-line with the expectations of the product datasheet from Dialog > Semiconductor. > > Bucks and LDOs now follow the expected notation: > { buck1, buck2, buck3, buck4 } > { ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10 } > > Signed-off-by: Steve Twiss > > --- > This patch applies against linux-next and v4.7 > > Hi, > > Several device tree source files use a regulator naming scheme different to > that found in the binding text document. Since those have been used > already, I would like ensure to the binding document follows those existing > DT file naming conventions. > > Please refer to the files containing da9052/53 references: > - ./arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi > - ./arch/arm/boot/dts/imx53-qsb.dts > > Those board files use the naming convention: > { buck1, buck2, buck3, buck4 } > { ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10 } > > Instead of the existing suggestion in the device tree binding file: > { buck0, buck1, buck2, buck3 } > { ldo4, ldo5, ldo6, ldo7, ldo8, ldo9, ldo10, ldo11, ldo12, ldo13 } > > The binding file regulator names (as it stands) does not reflect any > real-world uses I can find. This change would bring it in-line with > currect expectations from existing DTS files and make it similar enough to > the product datasheets to be "less confusing" than it currently is. > > Regards, > Steve > > See reference: > https://lkml.org/lkml/2016/7/25/197 > > > .../devicetree/bindings/mfd/da9052-i2c.txt | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) Otherwise, Acked-by: Rob Herring