Path: csiph.com!goblin3!goblin1!goblin.stu.neva.ru!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Markus Trippelsdorf Newsgroups: linux.kernel Subject: Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Date: Thu, 28 Jul 2016 20:10:01 +0200 Message-ID: References: X-Original-To: Borislav Petkov Dkim-Signature: v=1; a=rsa-sha256; c=simple; d=trippelsdorf.de; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=MnJACnZa7+8Kj6TEw4QlfbWLK/on jJ9edausGV5mWmY=; b=rwBT3JSmH/HAhsiXcgqdVn5ja8JDCjD6g6neYOw2Xxbc 3TVyq6hs2MCYM9Gt45P9e9Y6T1wvqpvBzXi2MEu7D6ClPcdqL+QakpDvTulhLj+V 5SHS1WTBd3aozCkM7Y3yV4Uq0lUBw4KQrgzVDmCTS6zr0HbVkBRRQwX+5uW5e7w= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 19 Organization: linux.* mail to news gateway X-Original-Cc: Ingo Molnar , Linus Torvalds , Sam Ravnborg , lkml , Michael Matz , linux-kbuild@vger.kernel.org, x86-ml X-Original-Date: Thu, 28 Jul 2016 19:56:47 +0200 X-Original-Message-ID: <20160728175647.GB316@x4> X-Original-References: <20140616132045.GE8170@pd.tnic> <20140616211405.GA7914@ravnborg.org> <20140624213835.GD15068@pd.tnic> <20140707105339.GA4776@pd.tnic> <20160728042011.GA25498@nazgul.tnic> <20160728082915.GA2349@gmail.com> <20160728084624.GA30084@nazgul.tnic> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1452035 On 2016.07.28 at 10:46 +0200, Borislav Petkov wrote: > On Thu, Jul 28, 2016 at 10:29:15AM +0200, Ingo Molnar wrote: > > BUT, isn't this the natural state of things, that the 'final' warnings > > that don't get fixed are the obnoxious, false positive ones - because > > anyone who looks at them will say "oh crap, idiotic compiler!"? > > Hmm, so my experience is like Linus' - that -Wmaybe thing generates too > much noise and a lot of false positives. The thing is, as Micha (on CC) > explained it to me, that warning simply says that GCC sometimes *cannot* > know whether the variable will be used uninitialized or not and eagerly > issues the warning message, just in case. Another issue is that the number of warnings you get depend on the optimization level. So -Os may be different from -O2 and once you use -O3 (I know it is not officially supported) you will drown in false positives... -- Markus