Path: csiph.com!eternal-september.org!feeder.eternal-september.org!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: tip-bot for Andy Lutomirski Newsgroups: linux.kernel Subject: [tip:x86/mm] x86/mm/cpa: Add missing comment in populate_pdg() Date: Sat, 23 Jul 2016 21:20:02 +0200 Message-ID: References: X-Original-To: linux-tip-commits@vger.kernel.org Reply-To: hpa@zytor.com, peterz@infradead.org, bp@alien8.de, mingo@kernel.org, luto@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org Git-Commit-ID: 55920d31f1e3fea06702c74271dd56c4fc9b70ca X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 42 Organization: linux.* mail to news gateway X-Original-Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, peterz@infradead.org, hpa@zytor.com, bp@alien8.de, mingo@kernel.org, luto@kernel.org X-Original-Date: Sat, 23 Jul 2016 12:18:45 -0700 X-Original-Message-ID: X-Original-References: <242baf8612394f4e31216f96d13c4d2e9b90d1b7.1469293159.git.luto@kernel.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1448995 Commit-ID: 55920d31f1e3fea06702c74271dd56c4fc9b70ca Gitweb: http://git.kernel.org/tip/55920d31f1e3fea06702c74271dd56c4fc9b70ca Author: Andy Lutomirski AuthorDate: Sat, 23 Jul 2016 09:59:28 -0700 Committer: Ingo Molnar CommitDate: Sat, 23 Jul 2016 21:17:10 +0200 x86/mm/cpa: Add missing comment in populate_pdg() In commit: 21cbc2822aa1 ("x86/mm/cpa: Unbreak populate_pgd(): stop trying to deallocate failed PUDs") I intended to add this comment, but I failed at using git. Signed-off-by: Andy Lutomirski Cc: Borislav Petkov Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/242baf8612394f4e31216f96d13c4d2e9b90d1b7.1469293159.git.luto@kernel.org Signed-off-by: Ingo Molnar --- arch/x86/mm/pageattr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c index 2bc6ea1..47870a5 100644 --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c @@ -1091,6 +1091,11 @@ static int populate_pgd(struct cpa_data *cpa, unsigned long addr) ret = populate_pud(cpa, addr, pgd_entry, pgprot); if (ret < 0) { + /* + * Leave the PUD page in place in case some other CPU or thread + * already found it, but remove any useless entries we just + * added to it. + */ unmap_pud_range(pgd_entry, addr, addr + (cpa->numpages << PAGE_SHIFT)); return ret;