Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From: Peter Chen <hzpeterchen@gmail.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH 10/21] usb: chipidea: msm: Rely on core to override  AHBBURST
Date: Thu, 30 Jun 2016 03:30:02 +0200
Message-ID: <rPyXM-39e-19@gated-at.bofh.it>
References: <rOcFX-8ei-3@gated-at.bofh.it> <rOcFX-8ei-1@gated-at.bofh.it> <rPhke-Kk-23@gated-at.bofh.it> <rPyXM-39e-21@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 28
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1434146

On Wed, Jun 29, 2016 at 11:59:21AM -0700, Stephen Boyd wrote:
> Quoting Peter Chen (2016-06-28 23:32:11)
> > On Sun, Jun 26, 2016 at 12:28:27AM -0700, Stephen Boyd wrote:
> > > The core framework already handles setting this parameter with a
> > > platform quirk. Add the appropriate flag so that we always set
> > > AHBBURST to 0. Technically DT should be doing this, but we always
> > > do it for msm chipidea devices so setting the flag in the driver
> > > works just as well.
> > 
> > You still need to set AHB burst value at dts, this flag is just for
> > override, see below:
> > 
> > ahb-burst-config = <0x0>;
> 
> Right, I have added that to dts now, but the CI_HDRC_OVERRIDE_AHB_BURST
> flag allows us to specify it from the platdata structure in the
> ci_hdrc_msm.c file. As the value is zero for msm type controllers, I
> left it out of the static definition of platdata because all the
> non-initialized members of that structure are going to be zero anyway. I
> can explicitly set it to zero to make it more clear if you like.

I suggest setting it explicitly at dts, at current code, it is set
as zero explicitly too:)

-- 

Best Regards,
Peter Chen