Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Peter Chen Newsgroups: linux.kernel Subject: Re: [PATCH 06/21] usb: chipidea: Initialize and reinitialize phy later Date: Thu, 30 Jun 2016 03:30:02 +0200 Message-ID: References: X-Original-To: Stephen Boyd Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q1O2oNMIxVvGagJfK/HpqWnc89NAAyluKqpcBF8QBhk=; b=MAh3M20MEk39fpcw3Kpn4YD1sFPvYCQIGvQ3rkE5l9HRS1T/4yjLfZGMFj43/fV9Jk FDqlR/cW5o3/NRY+XFKU35T305GmJXD5/xFc+NwCTHybcOKHIA6Nk7iqBammrsBd8W31 J3+Qx4g4ixatds7XriRPGeVkWK9QaR2x3zsiH1oHlxAYFDjpaSSqwSEVQP9COpqNiGi0 bIOl1V76ENXNTrk4GMcJWKJsRY5icJFmwxyKpczz5ZTTOGwNegrcw1EnxYlprZtJAy/X 9FQXocjb4tAshu9iS+IHt9ReuguWY8oK2wH9coIUokKhaC+OoLxWRInrm3FZQiaNTU4s mi7Q== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q1O2oNMIxVvGagJfK/HpqWnc89NAAyluKqpcBF8QBhk=; b=PK080lOjmhExkEJaSkSUdRj3bJWq2yWEntyjjXElh8wFrHcJ+Mk49TEGZZ3Ot+lone tOdDAR2a4H168N7x/zJWPmaBKcGHp7/R+t0K+gKkFUv434xpq+D/3qhUwf87VWd4SGN6 n3XAEJbCIXCeNKcvbSX3NWyugF7iDN5QwD5z8oGpzoiSewueCtxAqRM3D++NTdF4awD7 /t8qaj4Eojbrmj2lzqfMIaEPtni7vbjPtkI0IVfCqEa/iHAO1g9ZcuMYsfmh9k/+NoKa TGsrFH1dSFay1YhoFZgZIj0DaDWZ4QRJhzaJJ++5RmZ7daDkee0tJqppVEspsY985YO4 wgfw== X-Gm-Message-State: ALyK8tJ9KY98GJ8DoLoyvAai8aRG9PO7yBHMqbOZ1LJenkOQZimYGhrr+KPGnTd9IdLdqw== X-Received: by 10.98.89.85 with SMTP id n82mr16793926pfb.23.1467250166841; Wed, 29 Jun 2016 18:29:26 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 33 Organization: linux.* mail to news gateway X-Original-Cc: linux-usb@vger.kernel.org, Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Peter Chen , Greg Kroah-Hartman , Andy Gross , linux-arm-kernel@lists.infradead.org X-Original-Date: Thu, 30 Jun 2016 09:22:25 +0800 X-Original-Message-ID: <20160630012225.GA19928@shlinux2> X-Original-References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-7-stephen.boyd@linaro.org> <20160629023052.GB25236@shlinux2> <146724983020.16253.12640673678669134952@sboyd-linaro> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1434145 On Wed, Jun 29, 2016 at 06:23:50PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-06-28 19:30:52) > > On Sun, Jun 26, 2016 at 12:28:23AM -0700, Stephen Boyd wrote: > > > The ULPI phy on qcom platforms needs to be initialized and > > > powered on after a USB reset and before we toggle the run/stop > > > bit. Otherwise, the phy locks up and doesn't work properly. > > > > This requirement is so strange, try to see if any other initialization > > sequences. > > I think the problem is that the reset bit also resets the phy because > the phy is part of the same clock domain as the controller. Just a guess > though. > > > > > Since this driver is multi-platforms, I can't accept this change for > > common, if you had to do that, would you please move your changes to > > msm glue layer using CI_HDRC_CONTROLLER_RESET_EVENT and > > CI_HDRC_CONTROLLER_STOPPED_EVENT? Besides, you need to add one flag > > at ci_hdrc_platform_data.flags for your case to avoid normal > > initialization. > > Ok, let me see if I can make this work properly in the glue layer. I > take it that you want me to add a flag for this specific case so that we > don't do any phy control in the core and leave it up to the glue layer > to handle, like CI_HDRC_DISABLE_PHY_CONTROL or something? Yes -- Best Regards, Peter Chen