Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From: Joe Perches <joe@perches.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH 04/15] lirc_dev: replace printk with pr_* or dev_*
Date: Thu, 30 Jun 2016 02:30:01 +0200
Message-ID: <rPy1H-2Az-1@gated-at.bofh.it>
References: <rPnIZ-4Hd-3@gated-at.bofh.it> <rPnJ5-4Hd-23@gated-at.bofh.it>
X-Original-To: Andi Shyti <andi.shyti@samsung.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3874:4321:5007:6119:7974:8604:9040:9393:10004:10400:10848:11026:11232:11658:11783:11914:12296:12438:12517:12519:12740:13069:13161:13229:13311:13357:13439:13894:13972:14659:14721:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:25,LUA_SUMMARY:none
X-He-Tag: rain44_4143a9a80470e
X-Filterd-Recvd-Size: 1893
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu3
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 30
Organization: linux.* mail to news gateway
X-Original-Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
X-Original-Date: Wed, 29 Jun 2016 17:27:26 -0700
X-Original-Message-ID: <1467246446.24287.118.camel@perches.com>
X-Original-References: <1467206444-9935-1-git-send-email-andi.shyti@samsung.com> <1467206444-9935-5-git-send-email-andi.shyti@samsung.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1434123

On Wed, 2016-06-29 at 22:20 +0900, Andi Shyti wrote:
> This patch mutes also all the checkpatch warnings related to
> printk.
> 
> Reword all the printouts so that the string doesn't need to be
> split, which fixes the following checkpatch warning:

Adding

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any #include would allow these to be prefixed
automatically and allow the embedded prefixes to be removed.
> diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
[]
> @@ -240,59 +240,51 @@ static int lirc_allocate_driver(struct lirc_driver *d)
>  	int err;
>  
>  	if (!d) {
> -		printk(KERN_ERR "lirc_dev: lirc_register_driver: "
> -		       "driver pointer must be not NULL!\n");
> +		pr_err("lirc_dev: driver pointer must be not NULL!\n");
>  		err = -EBADRQC;
>  		goto out;
>  	}

		pr_err("driver pointer must not be NULL!\n");

And typical multiple line statement alignment is to
the open parenthesis.