Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod From: Wang Nan Newsgroups: linux.kernel Subject: [PATCH v12 4/8] perf record: Introduce rec->overwrite_evlist for overwritable events Date: Fri, 01 Jul 2016 04:30:01 +0200 Message-ID: References: X-Original-To: , X-Mailer: git-send-email 1.8.3.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.193.248] X-Cfilter-Loop: Reflected X-Mirapoint-Virus-Rapid-Raw: score=unknown(0), refid=str=0001.0A020206.5775D447.0132,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-ID: 26501ed50082efc5da45fbfcb294b54e Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 136 Organization: linux.* mail to news gateway X-Original-Cc: , , , Wang Nan , He Kuang , "Arnaldo Carvalho de Melo" , Jiri Olsa , "Masami Hiramatsu" , Namhyung Kim , "Nilay Vaish" X-Original-Date: Fri, 1 Jul 2016 02:23:47 +0000 X-Original-Message-ID: <1467339831-171169-5-git-send-email-wangnan0@huawei.com> X-Original-References: <1467339831-171169-1-git-send-email-wangnan0@huawei.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1434969 Create an auxiliary evlist for overwritable events. Before mmap, build this evlist and set 'overwrite' and 'backward' attribute. Since perf_evlist__mmap_ex() only maps events when evsel->overwrite matches evlist's corresponding attributes, with these two evlists an event goes to either rec->evlist or rec->overwrite_evlist. Signed-off-by: Wang Nan Cc: He Kuang Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Zefan Li Cc: Nilay Vaish Cc: pi3orama@163.com --- tools/perf/builtin-record.c | 59 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index b2b3b60..bad6e04 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -51,6 +51,7 @@ struct record { struct perf_data_file file; struct auxtrace_record *itr; struct perf_evlist *evlist; + struct perf_evlist *overwrite_evlist; struct perf_session *session; const char *progname; int realtime_prio; @@ -342,13 +343,41 @@ int auxtrace_record__snapshot_start(struct auxtrace_record *itr __maybe_unused) #endif +static int record__create_overwrite_evlist(struct record *rec) +{ + struct perf_evlist *evlist = rec->evlist; + struct perf_evsel *pos; + + evlist__for_each_entry(evlist, pos) { + if (!pos->overwrite) + continue; + + if (!rec->overwrite_evlist) { + rec->overwrite_evlist = perf_evlist__new_aux(evlist); + if (rec->overwrite_evlist) { + rec->overwrite_evlist->backward = true; + rec->overwrite_evlist->overwrite = true; + return 0; + } else + return -ENOMEM; + } + } + return 0; +} + static int record__mmap_evlist(struct record *rec, - struct perf_evlist *evlist) + struct perf_evlist *evlist, + bool overwrite) { struct record_opts *opts = &rec->opts; char msg[512]; - if (perf_evlist__mmap_ex(evlist, opts->mmap_pages, false, + /* + * Don't use evlist->overwrite because it is logically an + * internal attribute and is set by perf_evlist__mmap_ex(). + * Avoid circular dependency. + */ + if (perf_evlist__mmap_ex(evlist, opts->mmap_pages, overwrite, opts->auxtrace_mmap_pages, opts->auxtrace_snapshot_mode) < 0) { if (errno == EPERM) { @@ -373,7 +402,23 @@ static int record__mmap_evlist(struct record *rec, static int record__mmap(struct record *rec) { - return record__mmap_evlist(rec, rec->evlist); + int err; + + err = record__create_overwrite_evlist(rec); + if (err) + return err; + + err = record__mmap_evlist(rec, rec->evlist, false); + if (err) + return err; + + if (!rec->overwrite_evlist) + return 0; + + err = record__mmap_evlist(rec, rec->overwrite_evlist, true); + if (err) + return err; + return 0; } static int record__open(struct record *rec) @@ -698,9 +743,14 @@ static const struct perf_event_mmap_page *record__pick_pc(struct record *rec) { const struct perf_event_mmap_page *pc; + /* Change it to a loop if a new aux evlist is added */ pc = perf_evlist__pick_pc(rec->evlist); if (pc) return pc; + pc = perf_evlist__pick_pc(rec->overwrite_evlist); + if (pc) + return pc; + return NULL; } @@ -1311,6 +1361,7 @@ static struct record record = { .mmap2 = perf_event__process_mmap2, .ordered_events = true, }, + .overwrite_evlist = NULL, }; const char record_callchain_help[] = CALLCHAIN_RECORD_HELP @@ -1614,6 +1665,8 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused) err = __cmd_record(&record, argc, argv); out_symbol_exit: perf_evlist__delete(rec->evlist); + if (rec->overwrite_evlist) + perf_evlist__delete(rec->overwrite_evlist); symbol__exit(); auxtrace_record__free(rec->itr); return err; -- 1.8.3.4