Path: csiph.com!goblin1!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From: Andy Lutomirski <luto@amacapital.net>
Newsgroups: linux.kernel
Subject: Re: [PATCH 3/3] x86/dumpstack: Add show_stack_regs() and use it
Date: Sat, 25 Jun 2016 23:00:01 +0200
Message-ID: <rO2Qh-1HR-7@gated-at.bofh.it>
References: <rNuOB-5IF-9@gated-at.bofh.it> <rNuOB-5IF-15@gated-at.bofh.it>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fan7LDprgNiHDNIY7x3lJtWCIIbNLkXNq6zkEj0bnGM=; b=yZyb0/n3lAb+j2EZFo3bSDEF25OUqotQg3pghsbsmzs1bzyMEhQlNWB6aRKE0eibeC JZvjxAVmKr/pEVINjEtWYYpsCahO12mUCUuWEDNF12LBgGueiBN/Lc/FE5HlKPA1IPr0 gFLV02DjZGify5HJ2KuzwnIpM2vj+cad6M+fEGTQwj9V44K/Nk9Ma0i1gvC5iU9eVrr+ 1Pwip09OrJndypnXyP2BmSIRncUu0VjF8vtxtQYcbtPnokUr65TTPTmXJk663g3sUlwu zv06LU2akFT+ad992iBuKIXshAoGFdj9Ecmski0o7Wfj5iCYgUcUB9xrvlvjqgPqKVt4 NK2g==
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fan7LDprgNiHDNIY7x3lJtWCIIbNLkXNq6zkEj0bnGM=; b=YQulJSWi30mgczCGEPKBWhzy2iyqMd83s9vJSlauTp8DCSITW9bm0VvELVMnQ8HAUT GrDeBtXvy4ZYJP6yvQCuXX4alDqORNOgM0blCD9MT58bNmZNmUVuI/M4/s4FvvRKKaeo mWjzGil3epyto82xqkpP0LIgoozz2+qoUzgWIDNlfhrL/BayAMxagiZy8ycHU6D7dhqE TjLn21xPCgHqn78iYQ0XNN+IuPbhyeVNdV9Lh1qcM0jJtS4Ws7w81JLuDPzh2ePk5x81 3+e4qEl3a5y8hcle64jfhr7d6AzxWMVfXx23w8/b0KRJsKyJ2XE2P75vNsr6t8di2Qua HpXQ==
X-Gm-Message-State: ALyK8tI3xbJUmJFdEir4Jbs1kYYRUgnbrblxmtJcDO5KsRQpbWdxzvH7nfsmdvOC8klb0Zh24h3Z0oP/QCdf35lD
X-Received: by 10.31.33.80 with SMTP id h77mr5897240vkh.59.1466888095285; Sat, 25 Jun 2016 13:54:55 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 22
Organization: linux.* mail to news gateway
X-Original-Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org>, X86 ML <x86@kernel.org>
X-Original-Date: Sat, 25 Jun 2016 13:54:35 -0700
X-Original-Message-ID: <CALCETrXGwsrNKkpCDSsL_0k_NeugyL4EJ2eufmQDh1r2+RZq4Q@mail.gmail.com>
X-Original-References: <20160624083020.26871-1-bp@alien8.de> <20160624083020.26871-4-bp@alien8.de>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1431215

On Fri, Jun 24, 2016 at 1:30 AM, Borislav Petkov <bp@alien8.de> wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Add a helper to dump supplied pt_regs and use it in the MSR exception
> handling code to have precise stack traces pointing to the actual
> function causing the MSR access exception and not the stack frame of the
> exception handler itself.
>
> The new output looks like this:
>
>  unchecked MSR access error: RDMSR from 0xdeadbeef at rIP: 0xffffffff8102ddb6 (early_init_intel+0x16/0x3a0)
>   00000000756e6547 ffffffff81c03f68 ffffffff81dd0940 ffffffff81c03f10
>   ffffffff81d42e65 0000000001000000 ffffffff81c03f58 ffffffff81d3e5a3
>   0000800000000000 ffffffff81800080 ffffffffffffffff 0000000000000000
>  Call Trace:
>   [<ffffffff81d42e65>] early_cpu_init+0xe7/0x136
>   [<ffffffff81d3e5a3>] setup_arch+0xa5/0x9df
>   [<ffffffff81d38bb9>] start_kernel+0x9f/0x43a
>   [<ffffffff81d38294>] x86_64_start_reservations+0x2f/0x31
>   [<ffffffff81d383fe>] x86_64_start_kernel+0x168/0x176

Reviewed-by: Andy Lutomirski <luto@kernel.org>