Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Sudeep Holla Newsgroups: linux.kernel Subject: Re: [PATCH v2 0/3] firmware: scpi: add device power domain support Date: Mon, 20 Jun 2016 20:10:02 +0200 Message-ID: References: X-Original-To: Kevin Hilman Organization: ARM User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 44 X-Original-Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ulf Hansson , Jon Medhurst , Mathieu Poirier , Suzuki K Poulose X-Original-Date: Mon, 20 Jun 2016 19:02:43 +0100 X-Original-Message-ID: <57682FC3.3070504@arm.com> X-Original-References: <1466073481-697-1-git-send-email-sudeep.holla@arm.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1426887 On 20/06/16 18:56, Kevin Hilman wrote: > Sudeep Holla writes: > >> This series add support for SCPI based device device power state >> management using genpd. >> >> Regards, >> Sudeep >> >> v1[1]->v2: >> - Fixed the endianness handling in scpi_device_get_power_state >> as spotted by Tixy >> - Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf >> - Added Mark's ack on DT binding >> >> [1] https://marc.info/?l=linux-kernel&m=146522850003483&w=2 >> >> Sudeep Holla (3): >> firmware: arm_scpi: add support for device power state management >> Documentation: add DT bindings for ARM SCPI power domains >> firmware: scpi: add device power domain support using genpd > > Other than the couple nits on specific patches, > > Reviewed-by: Kevin Hilman > > And just a[nother] reminder to be sure to keep things that are Juno > specific well described since we know other vendors will be (and are > being) "creative" in their implementations of SCPI. > Agreed as mentioned in the other thread. I just sent a PR to arm-soc this afternoon. Do you think it's better to recall it and incorporate this ? Extremely sorry for rushing, I thought it would get too late. Ulf reviewed them so I rushed a bit. -- Regards, Sudeep