Path: csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Axel Lin Newsgroups: linux.kernel Subject: [PATCH RFT] regulator: tps51632: Fix setting ramp delay Date: Tue, 31 May 2016 11:30:02 +0200 Message-ID: X-Original-To: Mark Brown Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=FRF0bk8O6lyjRqZtT26HVji/8CBnp8TrEIiN4tVB5dk=; b=ymF/nIGcsi8MdGUT710BY6U2L/rKZgq0v3f8ILqqB1O+hKK9Ibe6Hao7XY3VCvWPSa ANH32XT6Q52cLfIJrW9NbnAMukXSukFLM2knJMP29Oo3kLdDJC+37SxrI1cfmwb9cG7p jwL1lsXZXkVFJguKGYKYVnNFN/3jaalUX76DwIQBWDZdYUw2szaTeyd2oGpvfqWmFx1k sqqhFiuercURuccrbpQfj2ZpeTGkmf5I2BfnUbtO6fLwRrzL/YhJFzkxSNSLIjwy6psi 49br/sETUsYE8Qr+xslRFX4AzyzGJBI8/axcVIXb8n6qgeiqlOh1Y6V+8S60V5JcYZFw EE5w== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=FRF0bk8O6lyjRqZtT26HVji/8CBnp8TrEIiN4tVB5dk=; b=Sv1e8jOPankf26E36r9IhryPVIM+PCKRnWcaGg0h8kv7uK0ek4uNaEAUpfP0sk9X2W sKkfcUas4AlhROdxnM8lJ5F0l4vto18pIOKDfwIv6JN07gdADYLa80IZyl45zDWULI7o jK4GIReAAS1jczw0erjhu92ObW+DNf9uT9G9D3+Hgns/68v7CNgdrMtXK+24if304HrA gpeknQ06CAbuU0ScdDqHvxOm5vo5aIfEhZU2ICSeFnrGbWB5k7Ydd0Si/NUs3EyNAbi2 Bceejo+J2pbNuk4yOeaoULhrU4o8P5KHZqIjOTsyrvavVdbKVckb2A8I3hW7Wo8S4B1k zAcw== X-Gm-Message-State: ALyK8tJcqLTjARujueOZ/Cit8DBu3XdLD6YxUmYnYD2w8DaOOC9tca0Snx0wxbpVQvBq0Q== X-Received: by 10.98.74.19 with SMTP id x19mr53210746pfa.79.1464686764845; Tue, 31 May 2016 02:26:04 -0700 (PDT) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 39 Organization: linux.* mail to news gateway X-Original-Cc: Laxman Dewangan , Liam Girdwood , linux-kernel@vger.kernel.org X-Original-Date: Tue, 31 May 2016 17:26:00 +0800 X-Original-Message-ID: <1464686760.11354.1.camel@ingics.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1410035 According to the datasheet: SLEW Register(Address = 07h) b7 b6 b5 b4 b3 b2 b1 b0 48mV/us 42mV/us 36mV/us 30mV/us 24mV/us 18mV/us 12mV/us 6mV/us Current code does not set correct slew rate in some cases: e.g. Assume ramp_delay is 10000, current code sets slew register to 6mV/us. Fix the logic to set slew register. Signed-off-by: Axel Lin --- drivers/regulator/tps51632-regulator.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/tps51632-regulator.c b/drivers/regulator/tps51632-regulator.c index 572816e..c139890 100644 --- a/drivers/regulator/tps51632-regulator.c +++ b/drivers/regulator/tps51632-regulator.c @@ -94,11 +94,14 @@ static int tps51632_dcdc_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) { struct tps51632_chip *tps = rdev_get_drvdata(rdev); - int bit = ramp_delay/6000; + int bit; int ret; - if (bit) - bit--; + if (ramp_delay == 0) + bit = 0; + else + bit = DIV_ROUND_UP(ramp_delay, 6000) - 1; + ret = regmap_write(tps->regmap, TPS51632_SLEW_REGS, BIT(bit)); if (ret < 0) dev_err(tps->dev, "SLEW reg write failed, err %d\n", ret); -- 2.5.0