Path: csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod From: Peter Zijlstra Newsgroups: linux.kernel Subject: Re: [PATCH] perf/x86/intel/rapl: add skylake server Date: Tue, 31 May 2016 11:30:01 +0200 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2012-12-30) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 27 Organization: linux.* mail to news gateway X-Original-Cc: LKML , Srinivas Pandruvada , Thomas Gleixner , Stephane Eranian X-Original-Date: Tue, 31 May 2016 11:29:08 +0200 X-Original-Message-ID: <20160531092908.GV3192@twins.programming.kicks-ass.net> X-Original-References: <1464107503-14968-1-git-send-email-jacob.jun.pan@linux.intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1410030 On Tue, May 24, 2016 at 09:31:43AM -0700, Jacob Pan wrote: > SKX uses similar RAPL interface as Broadwell server. > > Signed-off-by: Jacob Pan > --- > arch/x86/events/intel/rapl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c > index 1705c9d..70af62a 100644 > --- a/arch/x86/events/intel/rapl.c > +++ b/arch/x86/events/intel/rapl.c > @@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void) > break; > case 63: /* Haswell-Server */ > case 79: /* Broadwell-Server */ > + case 85: /* Skylake-Server */ > apply_quirk = true; > rapl_cntr_mask = RAPL_IDX_SRV; > rapl_pmu_events_group.attrs = rapl_events_srv_attr; This does not apply; please try against a more recent kernel. In specific commit: 4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver modular") seems to the 'problem'.