Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: "Paul E. McKenney" Newsgroups: linux.kernel Subject: Re: [PATCH 0/4] rcutorture: Several fixes to run selftest scripts on PPC Date: Thu, 19 May 2016 16:20:01 +0200 Message-ID: References: X-Original-To: Josh Triplett X-Ibm-Helo: d01dlp03.pok.ibm.com X-Ibm-Mailfrom: paulmck@linux.vnet.ibm.com X-Ibm-Rcptto: linux-kernel@vger.kernel.org Reply-To: paulmck@linux.vnet.ibm.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Tm-As-Mml: disable X-Content-Scanned: Fidelis XPS MAILER X-Cbid: 16051914-0045-0000-0000-0000043B92BA X-Ibm-Av-Detection: SAVI=unused REMOTE=unused XFE=unused Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 36 Organization: linux.* mail to news gateway X-Original-Cc: Boqun Feng , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan X-Original-Date: Thu, 19 May 2016 07:14:01 -0700 X-Original-Message-ID: <20160519141401.GO3528@linux.vnet.ibm.com> X-Original-References: <1463629344-20471-1-git-send-email-boqun.feng@gmail.com> <20160519042516.GA19073@x> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1403774 On Wed, May 18, 2016 at 09:25:17PM -0700, Josh Triplett wrote: > On Thu, May 19, 2016 at 11:42:20AM +0800, Boqun Feng wrote: > > I spend some time to make tools/testing/selftest/rcutorture run on PPC, > > here are some documention and fixes made while I was trying. > > > > The scripts are able to run and get results on PPC, however please > > note there are some stalls even build errors that could be found > > by the tests currently. > > > > As I'm certainly not an expert of qemu or bash programming, there > > may be something I am missing in those patches. So tests and comments > > are welcome ;-) > > > > Regards, > > Boqun > > > > Boqun Feng (4): > > rcutorture/doc: Add a new way to create initrd using dracut > > rcutorture: Use vmlinux as the fallback kernel image > > rcutorture: Make -soundhw a x86 specific option > > rcutorture: Don't specify the cpu type of QEMU on PPC > > All four of these seem reasonable to me: > Reviewed-by: Josh Triplett Thank you both! I have queued all four for further review and for testing. > I responded to the -soundhw patch, trying to track down why that option > was needed in the first place, and seeking a solution that doesn't > require adding to the set of target-specific options. But I don't think > that investigation should block your fix. Agreed, it should work better now than it did before! Thanx, Paul