Path: csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod From: David Miller Newsgroups: linux.kernel Subject: Re: [PATCH 00/13] RxRPC: Rewrite part 1 Date: Fri, 04 Mar 2016 23:30:01 +0100 Message-ID: References: X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) MIME-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 04 Mar 2016 14:20:12 -0800 (PST) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 36 Organization: linux.* mail to news gateway X-Original-Cc: linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Fri, 04 Mar 2016 17:20:10 -0500 (EST) X-Original-Message-ID: <20160304.172010.571829527806753588.davem@davemloft.net> X-Original-References: <20160304163705.31057.60831.stgit@warthog.procyon.org.uk> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1350644 From: David Howells Date: Fri, 04 Mar 2016 16:37:05 +0000 > Here's the first set of patches from my RxRPC rewrite, aimed at net-next. > These do some clean ups and bug fixes. Most of the changes are small, but > there are a couple of bigger changes: > > (*) Convert call flag numbers and event numbers into enums. Then rename > the event numbers to all have _EV_ in their name to stop confusion. > Fix one instance of an event bit being used instead of a flag bit. > > (*) A copy of the Rx protocol header is kept in the sk_buff private data. > Keep this in host byte order rather than network byte order as it > makes more sense. A number of other fields then get converted into > host byte order too. > > Conversion between host and network byte order is then done at the > packet reception/generation stage. > > The patches can be found here also: > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160304 > > This is based on net-next/master This looks really nice, pulled, thanks a lot David. Can you go through and use "unsigned int" instead of just plain "unsigned" in the RxRPC code? Thanks.