Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH V8 6/8] gpio: max77620: add gpio driver for MAX77620/MAX20024
Date: Sat, 20 Feb 2016 06:10:01 +0100
Message-ID: <r47XP-8mS-1@gated-at.bofh.it>
References: <r0Yem-8w1-7@gated-at.bofh.it> <r0Yem-8w1-15@gated-at.bofh.it> <r2AAV-7PX-3@gated-at.bofh.it>
X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 19 Feb 2016 21:06:06 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
X-Originating-IP: [10.19.65.30]
X-Clientproxiedby: BGMAIL101.nvidia.com (10.25.59.10) To bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 23
Organization: linux.* mail to news gateway
X-Original-Cc: Rob Herring <robh+dt@kernel.org>, =?UTF-8?B?UGF3ZcWCIE1vbGw=?= <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Alexandre Courbot <gnurou@gmail.com>, Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Liam Girdwood <lgirdwood@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>, Stephen Warren <swarren@nvidia.com>, Thierry Reding <treding@nvidia.com>, =?UTF-8?B?S3J6eXN6dG9mIEtvesWCb3dzaw==?= =?UTF-8?B?aQ==?= <k.kozlowski@samsung.com>
X-Original-Date: Sat, 20 Feb 2016 10:24:59 +0530
X-Original-Message-ID: <56C7F1A3.70404@nvidia.com>
X-Original-References: <1455191794-6065-1-git-send-email-ldewangan@nvidia.com>	<1455191794-6065-7-git-send-email-ldewangan@nvidia.com> <CACRpkdbA+pHHpjT-HMr8FS8DehRZE=G2m5s6=MRoqR4n_RrHEQ@mail.gmail.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1338637


On Tuesday 16 February 2016 04:48 AM, Linus Walleij wrote:
> On Thu, Feb 11, 2016 at 12:56 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO
>> pins. It also supports interrupts from these pins.
>>
>> Add GPIO driver for these pins to control via GPIO APIs.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> (...)
> Nit and no big deal:
>
>> +#include <linux/gpio.h>
> <linux/gpio/driver.h>
>
> should be enough.

Yaah, this is better.

Lee,
Should I respin the patch series for this change?