Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Darren Hart Newsgroups: linux.kernel Subject: Re: [PATCH][RESEND] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Date: Thu, 18 Feb 2016 06:40:02 +0100 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.24 (2015-08-30) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 16 Organization: linux.* mail to news gateway X-Original-Cc: Oleksandr Natalenko , corentin.chary@gmail.com, acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Wed, 17 Feb 2016 21:34:34 -0800 X-Original-Message-ID: <20160218053434.GF18421@dvhart-mobl5.amr.corp.intel.com> X-Original-References: <4f2df9dab959ad572e08eb7f7fa03220@natalenko.name> <20160217103738.GA1609@tyrael> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1337058 On Wed, Feb 17, 2016 at 12:37:38PM +0200, Giedrius Statkevičius wrote: > On Wed, Feb 17, 2016 at 09:45:05AM +0200, Oleksandr Natalenko wrote: > > Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module > > is loaded with wapf=4 option. Add quirk for this. > > --- > > You forgot Signed-off-by here. Always run your patch through > scripts/checkpatch.pl. Also, I think the format is usually > [PATCH RESEND vX AA/BB] and not [PATCH][RESEND]. RESEND means it's identical. v2 means there was a change. The change should be noted below the --- line. See Documentation/SubmittingPatches Section 14. -- Darren Hart Intel Open Source Technology Center