Path: csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH 1/4] ktime: add a roundup function
Date: Fri, 13 Nov 2015 23:40:02 +0100
Message-ID: <quvaG-3UL-9@gated-at.bofh.it>
References: <qusFP-2eI-3@gated-at.bofh.it> <qusFQ-2eI-29@gated-at.bofh.it> <qusZc-2Cc-15@gated-at.bofh.it>
X-Original-To: John Stultz <john.stultz@linaro.org>
X-Extloop1: 1
X-Ironport-Av: E=Sophos;i="5.20,289,1444719600"; d="scan'208";a="819496592"
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 22
X-Original-Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>, Arjan van de Ven <arjan@linux.intel.com>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Len Brown <len.brown@intel.com>, Rafael Wysocki <rafael.j.wysocki@intel.com>, Eduardo Valentin <edubezval@gmail.com>, Paul Turner <pjt@google.com>, jacob.jun.pan@linux.intel.com
X-Original-Date: Fri, 13 Nov 2015 14:33:16 -0800
X-Original-Message-ID: <20151113143316.29580923@icelake>
X-Original-References: <1447444387-23525-1-git-send-email-jacob.jun.pan@linux.intel.com> <1447444387-23525-2-git-send-email-jacob.jun.pan@linux.intel.com> <CALAqxLXDhe2G-7vomdMtoM=sLCavaywFZ=e5tBHa4y8=s137fg@mail.gmail.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1269350

On Fri, 13 Nov 2015 12:11:01 -0800
John Stultz <john.stultz@linaro.org> wrote:

> Could you add a comment as to what the function does, and use some
> better variable names here to make it more immediately obvious what is
> being done here?
> 
> Something like:
> /**
>  * ktime_roundup - Rounds value up to interval chunk
>  * @ value: Value to be rounded up
>  * @ interval: interval size to round up to
>  *
>  * Rounds a value up to the next higher multiple of an interval size
>  */
> static inline ktime ktime_roundup(ktime_t value, ktime_t interval)
will do. thank you for taking the time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/