Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: Azael Avalos Newsgroups: linux.kernel Subject: [PATCH RESEND] toshiba_acpi: Initialize hotkey_event_type variable Date: Wed, 04 Nov 2015 17:30:01 +0100 Message-ID: X-Original-To: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=dX4dj1f6DkfZ3DyI3kYKwy1Uuube2huCFTV7Vp8+r8M=; b=qu2XXGBsOw2oDq1X03Y4J4te7jTcIbTxpUJ5oXcKGOCuvdEv/lTVP5+9dUwYvRUYDS Muj/MINDXwig4pwY5U/crO8z4+4kvdxTsO6arMH50EijFqT8rYLh5D1ig1gfYJOtGd2S 36ystitBKqOB608GdA+J1oWnuecESORLnRPaPFnk8oZdTRlZBzLC9zry9v2FaSjLmEux HokeDdwt8WSjNYwM8BdCIZajSZwb71rWH0MJnz7UHExzWJT7ehB9pXI2Rw9H8iEeZCJL MqG+mAnLTzxdSGt/JQMt4hyos7hlKCBJcVLB6B/j79XQstsNXQkHYq2Qhq6HFRdRfnlh f5ig== X-Received: by 10.202.211.82 with SMTP id k79mr1377632oig.32.1446654529892; Wed, 04 Nov 2015 08:28:49 -0800 (PST) X-Mailer: git-send-email 2.6.2 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 34 Organization: linux.* mail to news gateway X-Original-Cc: Azael Avalos , stable@vger.kernel.org X-Original-Date: Wed, 4 Nov 2015 09:28:26 -0700 X-Original-Message-ID: <1446654506-3730-1-git-send-email-coproscefalo@gmail.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1262421 Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some toshiba models") fixed an issue on some laptops regarding hotkeys registration, however, if failed to address the initialization of the hotkey_event_type variable, and thus, it can lead to potential unwanted effects as the variable is being checked. This patch initializes such variable to avoid such unwanted effects. Cc: # 4.1+ Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index beb709f..c013029 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -2665,6 +2665,7 @@ static int toshiba_acpi_add(struct acpi_device *acpi_dev) ret = toshiba_function_keys_get(dev, &dev->special_functions); dev->kbd_function_keys_supported = !ret; + dev->hotkey_event_type = 0; if (toshiba_acpi_setup_keyboard(dev)) pr_info("Unable to activate hotkeys\n"); -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/