Path: csiph.com!xmission!news.glorb.com!diesel.cu.mi.it!bofh.it!news.nic.it!robomod From: Arnd Bergmann Newsgroups: linux.kernel Subject: [PATCH 16/19] staging/wilc1000: remove WILC_SDIO/WILC_SPI macros Date: Wed, 21 Oct 2015 01:00:02 +0200 Message-ID: References: X-Original-To: linux-wireless@vger.kernel.org X-Mailer: git-send-email 2.1.0.rc2 X-Provags-ID: V03:K0:GbGMc/rOAi8iM+WSkWw7yRnPGwnsRd4H9fq7vlWR2doWjoa+xvw 7Lr56vRKan96Gv+pvNsLDeS71OfI6mGjcRa26QvqOmnrkmzkLkQbsYovJAuNkPt4kuzV4SS qjDasAqcprdX+iwrzuPfSCI2z36TQyTmRFwyhR74dkx1k3tn7c36Ybd+04aFo+QfIzcVdJV 7JnFlvoOSuSIMQphJRL2A== X-Ui-Out-Filterresults: notjunk:1;V01:K0:KCNq7p9yzbM=:Xv1S3vbiAk2EEWCenXbbat J4X4MHBP8wVICBLwUlzpinIEWMEfkSG6x8xksY0hF7QwGE6ej5q+k1/LKSDoMP3qszCoqNTck K0fsRz3lHewiavU59SRExHYbEQHrSd3YAIvpDgK8rNVJB+5Jf+1HG2Tw6gvJhknXErmDZsvZ8 /iAr9sDgchzOs71AQz0SimmVKI2UkteMKn2ZTNG6ESn7rCp0MyYdEVt/MEMNe464wJnzeTViJ tZWip1MxGSITurDlPm2XjOmbS6y7c/zARm+4nWX6UhFOqQrn62q5BItI4y8n0n/TnFssBu44m J36UyQMCkAEJXqqUmIMHHd6ProY7a2esOabkkrzhHyonLpT/0Wc3JQbgBB2TWqZGtq2dxGDHx LKKEVvBXlCBZ3pP40rwPMK9Ez8Li6DnOSz4iX/ZBYS4Io4LV/iclWLyPJ18gj6d//v+2j7yIK WJy/qTmYMgzryH4BC9fOn81GxH0qds51JlIvDVZVFMRFMIslJTrqIIaReDCoESGlOqzwV2ZIG a0twJV9Xw8APrKIPbf49F/9QPE7Ju1xhEKPS4jmJIrSmn9UFu+UN1Xh2xfcwCSZJh4NUYSkT2 BwGtFQobw3TRgiTw1E/4yEzpI/NttXqZxvX40IbKiMsDq4w1QJGNvdakdD8TZAhYFOd0lx8nV ZbqHKMyDUSgTbpxe4tQsS+ZjOm+oNF670Zp2GU4S9XniJEHYRCAfho3qrAn0AtQVNb7Y= Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 68 Organization: linux.* mail to news gateway X-Original-Cc: Rachel Kim , devel@driverdev.osuosl.org, Chris Park , gregkh@linuxfoundation.org, Stanislav Kholmanskikh , Johnny Kim , linux-kernel@vger.kernel.org, Tony Cho , Glen Lee , Leo Kim , Arnd Bergmann X-Original-Date: Wed, 21 Oct 2015 00:47:35 +0200 X-Original-Message-ID: <1445381258-1455986-17-git-send-email-arnd@arndb.de> X-Original-References: <1445381258-1455986-1-git-send-email-arnd@arndb.de> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1252324 The last remaining user of WILC_SDIO macro checks for the correct time to wait in an interrupt for the PLL to settle. We can replace this with a runtime check and remove both WILC_SDIO and WILC_SPI, as we no longer need conditional compilation based on the hardware type. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/Makefile | 3 +-- drivers/staging/wilc1000/wilc_wlan.c | 5 ++++- drivers/staging/wilc1000/wilc_wlan.h | 7 ++----- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/Makefile b/drivers/staging/wilc1000/Makefile index b96fee8f94f2..9ce30e92ea3a 100644 --- a/drivers/staging/wilc1000/Makefile +++ b/drivers/staging/wilc1000/Makefile @@ -1,7 +1,6 @@ obj-$(CONFIG_WILC1000) += wilc1000.o -ccflags-$(CONFIG_WILC1000_SDIO) += -DWILC_SDIO -DCOMPLEMENT_BOOT -ccflags-$(CONFIG_WILC1000_SPI) += -DWILC_SPI +ccflags-$(CONFIG_WILC1000_SDIO) += -DCOMPLEMENT_BOOT ccflags-y += -DSTA_FIRMWARE=\"atmel/wilc1000_fw.bin\" \ -DAP_FIRMWARE=\"atmel/wilc1000_ap_fw.bin\" \ diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index d12a4e7df32c..038c9b2eee6c 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c @@ -1238,7 +1238,10 @@ static void wilc_pllupdate_isr_ext(u32 int_stats) g_wlan.hif_func.hif_clear_int_ext(PLL_INT_CLR); /* Waiting for PLL */ - mdelay(WILC_PLL_TO); + if (g_wlan.io_func->io_type == HIF_SDIO) + mdelay(WILC_PLL_TO_SDIO); + else + mdelay(WILC_PLL_TO_SPI); /* poll till read a valid data */ while (!(ISWILC1000(wilc_get_chipid(true)) && --trials)) { diff --git a/drivers/staging/wilc1000/wilc_wlan.h b/drivers/staging/wilc1000/wilc_wlan.h index 2e9b5d50ff7e..2f636534fc5d 100644 --- a/drivers/staging/wilc1000/wilc_wlan.h +++ b/drivers/staging/wilc1000/wilc_wlan.h @@ -143,11 +143,8 @@ #define WILC_CFG_RSP_STATUS 2 #define WILC_CFG_RSP_SCAN 3 -#ifdef WILC_SDIO -#define WILC_PLL_TO 4 -#else -#define WILC_PLL_TO 2 -#endif +#define WILC_PLL_TO_SDIO 4 +#define WILC_PLL_TO_SPI 2 #define ABORT_INT BIT(31) -- 2.1.0.rc2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/