Path: csiph.com!au2pb.net!feeder.erje.net!us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: =?UTF-8?q?Pali=20Roh=C3=A1r?= Newsgroups: linux.kernel Subject: [PATCH] bq2415x_charger: Fix null pointer dereference Date: Mon, 21 Sep 2015 17:00:02 +0200 Message-ID: X-Original-To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=xkX/jJC1kSxz3R2bseC0zMEbk+TDTxgkMiir8iArWeo=; b=sxr1qEfLqwdIbG/hT0+RLjfuTzErltH4lxoqqD3qQzSTjgak2NSt8xbKUaOvwsTXct llZNIAtibHHzxzhjs5Bu3XS6y3cykQNzL60RYO9/jTq17eDdKJfw9/0hIis3c0Ryl98r 2Nyo67iEJwMzmPxMu49iIzN26YFTS2anYNkpYX9mHlURYFI0y3+47lj1C9TjFma74eo2 DUWF2//QL9HBWjAR86N+qYv4lwz8YW1YEiT3Qm14FuBmHnQAD4h0DIs48KqeqnzACsMd ND/TNLmFHYb9v2VgzUTqamxp9eNiRyDeKq7wOfrxGFgcLBLWWm9Ijtt42pRswUaF0rTl YVwA== X-Received: by 10.180.101.198 with SMTP id fi6mr14852334wib.25.1442847520642; Mon, 21 Sep 2015 07:58:40 -0700 (PDT) X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 31 Organization: linux.* mail to news gateway X-Original-Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , =?UTF-8?q?Pali=20Roh=C3=A1r?= X-Original-Date: Mon, 21 Sep 2015 16:58:20 +0200 X-Original-Message-ID: <1442847500-22435-1-git-send-email-pali.rohar@gmail.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1229443 Commit b68c3161430a (bq2415x_charger: Allow to load and use driver even if notify device is not registered yet) introduced null pointer dereference in case bq is NULL. This patch fixes it. Signed-off-by: Pali Rohár Reported-by: Dan Carpenter --- drivers/power/bq2415x_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c index ec212b5..4afd768 100644 --- a/drivers/power/bq2415x_charger.c +++ b/drivers/power/bq2415x_charger.c @@ -1704,7 +1704,7 @@ error_4: error_3: bq2415x_power_supply_exit(bq); error_2: - if (bq->notify_node) + if (bq && bq->notify_node) of_node_put(bq->notify_node); kfree(name); error_1: -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/