Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Luca Abeni Newsgroups: linux.kernel Subject: Re: [RFC 4/8] Improve the tracking of active utilisation Date: Thu, 28 Jan 2016 22:20:02 +0100 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unitn-it.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=N9TlC1dKV34Mo4Jus7moKdE6r8A94zn1ilUyBXejEE0=; b=sxua3lMj4UFoJlybBJ7KhlhcOzuP80z18to6/8FlT8RDzaty/8XjsbfRXm+xP13tm3 ue1RID07+kjjYD7ljMRLYdKSGUB/m/BpAa/PuBHOx8xnv5hc+SuAxA5S4w7bEUxOSry6 4ynMvbi4C18oK+p7GnZYYDEmWg0FrcBxPDnaFSaZ9zrG1WqineKaVAcgL10wOPmERDMv mv1tknvVDDRG5T07rDSkltCwRmqhE0Fmio5VMhty3zKOTp8DzDmuskYvazJGJZyXV9vK M8R+HR8wMT6R3FiW2XwgKWMAozAiztKLNLZocMwNuIQNnTiutB1iTp5lj6tLVeh+rgfM GQHQ== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=N9TlC1dKV34Mo4Jus7moKdE6r8A94zn1ilUyBXejEE0=; b=l36NiecbCPoWhqbJXdJSpatpGUB/zWLPvwI+Qc1WK6q3DZwriKurQ/Uw1EtQ4X2n8M pTZhHlRgmyWVv7MLoGG9JVHeqUkrPi+Ig3WHD1Rk6BzvGP6BrTuwvy/s9DvMz46pjDZ9 kBkGsnjtrd7jfyHO9uWDXjdvP71CIKxsbyTaHoezMfgn1TR42qf/f2WTMytEtsIcM2Y4 JmbqE0iNMcAHfgClSJaKy4glxJAMZrRBZOU3vJo4gclvp3bIe6yIjgDmYWrzlrw5bTgN k8Fc2d5ohkEElZvoVlPL30aoT/ACmklOTJyCoMJsXrfhbLbg0OE6UMLra8u2F23o3M1W U43g== X-Gm-Message-State: AG10YOS7YGpRE9BTRU+S1JJuCvcgyIyOqneuL50Afum3rS4NKKpU3StsxjZpufIzfN39Dn1Z X-Received: by 10.194.133.233 with SMTP id pf9mr5214291wjb.75.1454015737020; Thu, 28 Jan 2016 13:15:37 -0800 (PST) X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 47 Organization: linux.* mail to news gateway X-Original-Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Juri Lelli X-Original-Date: Thu, 28 Jan 2016 22:15:32 +0100 X-Original-Message-ID: <20160128221532.71a76bec@luca-1225C> X-Original-References: <1452785094-3086-1-git-send-email-luca.abeni@unitn.it> <1452785094-3086-5-git-send-email-luca.abeni@unitn.it> <20160114194323.GC6357@twins.programming.kicks-ass.net> <569E29FD.9040909@unitn.it> <20160119134739.GY6357@twins.programming.kicks-ass.net> <20160127143651.4de18ad9@luca-1225C> <20160127143946.GR6357@twins.programming.kicks-ass.net> <20160128121441.0ebde65d@utopia> <20160128122100.GD6357@twins.programming.kicks-ass.net> <20160128144129.789ca176@utopia> <20160128140053.GR6356@twins.programming.kicks-ass.net> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1321066 On Thu, 28 Jan 2016 15:00:53 +0100 Peter Zijlstra wrote: > On Thu, Jan 28, 2016 at 02:41:29PM +0100, luca abeni wrote: > > > > Some day we should fix this :-) > > > I am trying to have a better look at the code, and I think that > > implementing bandwidth inheritance (BWI) could be easy (implementing > > M-BWI, that can be analyzed on multi-processor systems, is more > > complex because it requires busy waiting or similar). > > Ah indeed, I remember now. To which I said that if busy-waiting is > 'correct' so then must not busy-waiting be, for that consumes less > cputime and would allow more actual work to be done. The issue is that when the task wakes up after blocking, the scheduler has to check if the current deadline and runtime can still be used (and if they cannot, it generates a new deadline). Of course a blocking solution can work, but the strategy used to check if deadline and runtime are still valid must be changed. I discussed this with the M-BWI authors about one year ago, but we did not arrive to a definitive conclusion. Anyway, I suspect that implementing BWI (without the "M-"), which has no busy-waiting, could be an improvement respect to the current mechanism. Thanks, Luca > > Of course, I might have missed some subtle detail, but intuition > suggests the above. > > > > Nope, but fixing this is likely to be non-trivial. > > > Ok... So, if this is acceptable for this patchset I'll try to keep > > the current PI behaviour, > > Yeah that's fine. That's decidedly outside the scope of these patches. > > > and I'll try to have a look at a better PI > > protocol after the runtime reclaiming stuff is done (that is, I > > make it acceptable for mainline, or we decide that a different > > approach is needed). > > That would be very nice indeed!