Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Johannes Berg <johannes@sipsolutions.net>
Newsgroups: linux.kernel
Subject: Re: net/rfkill: WARNING in rfkill_fop_read
Date: Tue, 26 Jan 2016 11:10:01 +0100
Message-ID: <qV8Jr-2AB-7@gated-at.bofh.it>
References: <qV8zM-2fZ-29@gated-at.bofh.it> <qV8Jr-2AB-9@gated-at.bofh.it> <qV8zM-2fZ-29@gated-at.bofh.it>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.1-1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 23
Organization: linux.* mail to news gateway
X-Original-Cc: syzkaller <syzkaller@googlegroups.com>, Kostya Serebryany <kcc@google.com>, Alexander Potapenko <glider@google.com>, Sasha Levin <sasha.levin@oracle.com>, Eric Dumazet <edumazet@google.com>
X-Original-Date: Tue, 26 Jan 2016 11:08:08 +0100
X-Original-Message-ID: <1453802888.2759.11.camel@sipsolutions.net>
X-Original-References: <CACT4Y+a9pNis4UH3zV4PCD5DhY-wk1+eRU8s-SM2Bm5mjpPiOg@mail.gmail.com> (sfid-20160126_105528_655164_E24E3E9D) <CACT4Y+a9pNis4UH3zV4PCD5DhY-wk1+eRU8s-SM2Bm5mjpPiOg@mail.gmail.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1317690

On Tue, 2016-01-26 at 10:55 +0100, Dmitry Vyukov wrote:
> Hello,
> 
> The following program triggers WARNING message in rfkill_fop_read:
> 
> ------------[ cut here ]------------
> WARNING: CPU: 2 PID: 6975 at kernel/sched/core.c:7663
> __might_sleep+0x138/0x1a0()
> do not call blocking ops when !TASK_RUNNING; state=1 set at
> [<ffffffff81436e01>] prepare_to_wait_event+0x141/0x410
> kernel/sched/wait.c:210

>  [<     inline     >] rfkill_readable net/rfkill/core.c:1102

Yeah, this should not acquire the mutex ... but luckily it's not a
problem not to anyway, so it's easy to fix. Thanks! I'll send out a fix
once I've tested it.

> // autogenerated by syzkaller (http://github.com/google/syzkaller)

gotta love the raw mmap etc. :)

johannes