Path: csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod From: Kamal Mostafa Newsgroups: linux.kernel Subject: Re: [PATCH 4.2.y-ckt 009/211] xhci: don't finish a TD if we get a short transfer event mid TD Date: Wed, 06 Jan 2016 21:00:03 +0100 Message-ID: References: X-Original-To: Ben Hutchings , Luis Henriques Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 41 Organization: linux.* mail to news gateway X-Original-Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, Mathias Nyman , Greg Kroah-Hartman X-Original-Date: Wed, 06 Jan 2016 11:55:00 -0800 X-Original-Message-ID: <1452110100.4431.18.camel@fourier> X-Original-References: <1452023119-25647-1-git-send-email-kamal@canonical.com> <1452023119-25647-10-git-send-email-kamal@canonical.com> <1452099937.2768.123.camel@decadent.org.uk> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1303034 On Wed, 2016-01-06 at 17:05 +0000, Ben Hutchings wrote: > On Tue, 2016-01-05 at 11:41 -0800, Kamal Mostafa wrote: > > 4.2.8-ckt1 -stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Mathias Nyman > > > > commit e210c422b6fdd2dc123bedc588f399aefd8bf9de upstream. > > > > If the difference is big enough between the bytes asked and received > > in a bulk transfer we can get a short transfer event pointing to a TRB in > > the middle of the TD. We don't want to handle the TD yet as we will anyway > > receive a new event for the last TRB in the TD. > > > > Hold off from finishing the TD and removing it from the list until we > > receive an event for the last TRB in the TD > > > > Signed-off-by: Mathias Nyman > > Signed-off-by: Greg Kroah-Hartman > > [ kamal: backport to 4.2-stable: context ] > > Signed-off-by: Kamal Mostafa > [...] > > This causes regressions (see https://bugs.debian.org/808602 and > https://bugs.debian.org/808953 ) so please hold off until there's a > complete fix upstream. Thanks for the heads-up, Ben. I'll defer it for 4.2-stable. I'm thinking that it should also be reverted from the stable kernels that already carry it (3.2, 3.13, 3.16, 3.19), unless that complete upstream fix is really imminent. Is it? -Kamal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/