Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: Javier Martinez Canillas Newsgroups: linux.kernel Subject: Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses Date: Mon, 07 Sep 2015 12:40:02 +0200 Message-ID: References: X-Original-To: Sjoerd Simons , linux-rockchip@lists.infradead.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 38 Organization: linux.* mail to news gateway X-Original-Cc: linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Kukjin Kim , Krzysztof Kozlowski , Thierry Reding , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Russell King , Alexandre Belloni , Arnd Bergmann , Lee Jones , Olof Johansson , Ray Jui , Stephen Warren X-Original-Date: Mon, 7 Sep 2015 12:38:08 +0200 X-Original-Message-ID: <55ED6910.8010202@osg.samsung.com> X-Original-References: <1441570566-14001-1-git-send-email-sjoerd.simons@collabora.co.uk> <1441570566-14001-2-git-send-email-sjoerd.simons@collabora.co.uk> <55ED585B.9030009@osg.samsung.com> <1441621467.8778.26.camel@collabora.co.uk> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1220045 Hello Sjoerd, On 09/07/2015 12:24 PM, Sjoerd Simons wrote: > On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote: >> Hello Sjoerd, >> >> On 09/06/2015 10:16 PM, Sjoerd Simons wrote: >>> Enable Rockchip I2C, SPI, PWM, thermal drivers. >>> >>> Builtin are: >>> * I2C as it often controls the pmic. >> >> Having I2C as a module will cause more probe deferrals due missing >> regulators and slow down the boot but it should not cause issues. >> Or am I missing something? >> >> In fact, I think even the PMIC could be built as a module. > > It could in principle. However as a lot of other drivers do need the > regulators provided by the pmic, they'll be deferred until that driver > is loaded. So e.g. with the i2c/pmic drivers as a module you cannot > boot to an NFS rootfs without using an initramfs. > Right, not needing an initramfs is certainly a good reason. If you could add something like that in the commit message of patches 1/4 and 2/4 that would be great. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/