Path: csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod From: Heiko =?ISO-8859-1?Q?St=FCbner?= Newsgroups: linux.kernel Subject: Re: [PATCH v5 2/2] pinctrl: rockchip: only enable gpio clock when it setting Date: Thu, 13 Aug 2015 14:40:03 +0200 Message-ID: References: X-Original-To: Linus Walleij User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 28 Organization: linux.* mail to news gateway X-Original-Cc: Lin Huang , Doug Anderson , "open list:ARM/Rockchip SoC..." , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" X-Original-Date: Thu, 13 Aug 2015 14:37:36 +0200 X-Original-Message-ID: <2167165.ooWgarx4Ov@diego> X-Original-References: <1439287924-6988-1-git-send-email-hl@rock-chips.com> <1439287924-6988-2-git-send-email-hl@rock-chips.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1206781 Hi Linus, Am Donnerstag, 13. August 2015, 14:24:28 schrieb Linus Walleij: > On Tue, Aug 11, 2015 at 12:12 PM, Lin Huang wrote: > > gpio can keep state even the clock disable, for save power > > consumption, only enable gpio clock when it setting > > > > Signed-off-by: Lin Huang > > Reviewed-by: Heiko Stuebner > > --- > > Changes in v5: > > -rebase patch > > Patch applied with Doug's test tags etc. did you also take the first patch? Aka bot should probably stay together (hence Stephen's Ack for the clock change), as the dynamically controlling the gpio clocks exposes the pclk_pd_pmu. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/