Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Sergei Shtylyov Newsgroups: linux.kernel Subject: Re: [PATCH v2 15/25] memconsole: fix __iomem mishandling, switch to memremap Date: Sun, 26 Jul 2015 00:10:01 +0200 Message-ID: References: X-Original-To: Dan Williams , tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=nXmFUI50AQjjeCwz1RfkMwmtsPJ9rbyRFHxcABRMKJQ=; b=SFVAHG2DjGjGhUGQS61WPKMZUEXvl6w2l617DtR6USdlxjQybhK2ydGEHqaEQzZTkk bYse6vjg7SXByF55xra2rA8j5zOisRT8IhXsSjZvPJWHHhQvW82VhYPb/I0I+vFLl/Cq tM//VPybIN5l/tJeWTYo7My6uEMJigIKn60GXZgS24krIR4VYJK13a/+3HTNpyTov5pI sMyyOBW8x2FWKAkTlg219OlS0muRXAiWf2otLuY5ZwoIIV4n8+BebQpx/ggHOeXCMGyk DbqCES7Ejl1JZNsM5j6bEBUy0KLo/ywlQFSU7LF49VSP1K7bFIoMZDYTIEzDHJDguZtj WL9Q== X-Gm-Message-State: ALoCoQk+rWFAyFtCt3gyTNzh14hwUblVN1xOMoo+YME/J4UIPMLoFYsbMCduj1qqrKblKGG9mVUW X-Received: by 10.112.171.68 with SMTP id as4mr20036414lbc.64.1437861755791; Sat, 25 Jul 2015 15:02:35 -0700 (PDT) Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 51 X-Original-Cc: linux-arch@vger.kernel.org, toshi.kani@hp.com, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Mike Waychison , rmk+kernel@arm.linux.org.uk, hch@lst.de, linux-arm-kernel@lists.infradead.org X-Original-Date: Sun, 26 Jul 2015 01:02:32 +0300 X-Original-Message-ID: <55B40778.4010909@cogentembedded.com> X-Original-References: <20150725023649.8664.59145.stgit@dwillia2-desk3.amr.corp.intel.com> <20150725023923.8664.66965.stgit@dwillia2-desk3.amr.corp.intel.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: aioe.org linux.kernel:1192439 Hello. On 07/25/2015 05:39 AM, Dan Williams wrote: > The memconsole driver is not using proper accessors for __iomem. Switch > to memremap to fix this issue, and this also prepares the driver for the > removal of ioremap_cache. > Cc: Mike Waychison > Signed-off-by: Dan Williams > --- > drivers/firmware/google/memconsole.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > diff --git a/drivers/firmware/google/memconsole.c b/drivers/firmware/google/memconsole.c > index 2f569aaed4c7..1b25fba84f32 100644 > --- a/drivers/firmware/google/memconsole.c > +++ b/drivers/firmware/google/memconsole.c > @@ -52,14 +52,15 @@ static ssize_t memconsole_read(struct file *filp, struct kobject *kobp, > char *memconsole; > ssize_t ret; > > - memconsole = ioremap_cache(memconsole_baseaddr, memconsole_length); > + memconsole = memremap(memconsole_baseaddr, memconsole_length, > + MEMREMAP_CACHE); Could you maintain the existing style of the broken line alignment in this file? > if (!memconsole) { > - pr_err("memconsole: ioremap_cache failed\n"); > + pr_err("memconsole: memremap failed\n"); > return -ENOMEM; > } > ret = memory_read_from_buffer(buf, count, &pos, memconsole, > memconsole_length); Here's an example... > - iounmap(memconsole); > + memunmap(memconsole); > return ret; > } MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/