Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Rob Herring Newsgroups: linux.kernel Subject: [PATCH v2 05/13] gpu/drm: kill off set_irq_flags usage Date: Sun, 12 Jul 2015 16:30:01 +0200 Message-ID: References: X-Original-To: linux-arm-kernel@lists.infradead.org, Russell King Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=9kyW5XLNDgHrrMO++s4cjmuR1JWQUL2sL6q2/FoGLR8=; b=ctcnocFOCxzllYYRIqxMQw7AUSmtBFhek+7ZXT714X75CRShHEM7okydao9tvXpR5u g3YYEK5xE4DR2KoFrwPw80HlmQPyTtPzrMbB1daQ0uJbxHYgtU/uOnI+UJ9u4E2dnmzX tyFqUVsvsl0qtLYudp2IQUHc3q9dJOs7XQDhrGcK9GNIcOi887ufRiEfjsP4A4PmFzgR E18DRh+4dCq9WCLagMpVho1WeCKXEAXELfCVVwtDNEJeiyZCjVHDCyBKIfXfAa/8k+dn AP7hQDc/6CsP24Yz3vNrjgU/fLrn7SLBRlPDhceihbVpBWp6putlkrX1rolK+HqPiGtU Y1kA== X-Received: by 10.60.177.195 with SMTP id cs3mr19647929oec.37.1436711223561; Sun, 12 Jul 2015 07:27:03 -0700 (PDT) X-Mailer: git-send-email 2.1.0 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 57 Organization: linux.* mail to news gateway X-Original-Cc: linux-kernel@vger.kernel.org, arm@kernel.org, David Airlie , dri-devel@lists.freedesktop.org X-Original-Date: Sun, 12 Jul 2015 09:26:43 -0500 X-Original-Message-ID: <1436711211-18223-6-git-send-email-robh@kernel.org> X-Original-References: <1436711211-18223-1-git-send-email-robh@kernel.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: aioe.org linux.kernel:1182359 set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID -> !IRQ_NOREQUEST IRQF_PROBE -> !IRQ_NOPROBE IRQF_NOAUTOEN -> IRQ_NOAUTOEN For IRQs managed by an irqdomain, the irqdomain core code handles clearing and setting IRQ_NOREQUEST already, so there is no need to do this in .map() functions and we can simply remove the set_irq_flags calls. Some users also set IRQ_NOPROBE and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c | 1 - drivers/gpu/ipu-v3/ipu-common.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c index 33bd4c6..9a6a747 100644 --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_irq.c @@ -165,7 +165,6 @@ static int mdp5_hw_irqdomain_map(struct irq_domain *d, irq_set_chip_and_handler(irq, &mdp5_hw_irq_chip, handle_level_irq); irq_set_chip_data(irq, mdp5_kms); - set_irq_flags(irq, IRQF_VALID); return 0; } diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c index 6d2f39d..cf0cf46 100644 --- a/drivers/gpu/ipu-v3/ipu-common.c +++ b/drivers/gpu/ipu-v3/ipu-common.c @@ -1099,8 +1099,7 @@ static int ipu_irq_init(struct ipu_soc *ipu) } ret = irq_alloc_domain_generic_chips(ipu->domain, 32, 1, "IPU", - handle_level_irq, 0, - IRQF_VALID, 0); + handle_level_irq, 0, 0, 0); if (ret < 0) { dev_err(ipu->dev, "failed to alloc generic irq chips\n"); irq_domain_remove(ipu->domain); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/