Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Rob Herring Newsgroups: linux.kernel Subject: [PATCH v2 07/13] memory: kill off set_irq_flags usage Date: Sun, 12 Jul 2015 16:30:01 +0200 Message-ID: References: X-Original-To: linux-arm-kernel@lists.infradead.org, Russell King Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1CLdV/7/98dfRoCF0//xE+CAUUQJjiM3pLPaSDPs/E0=; b=K7upgxHECa1YsChRh7rMIXNP0MkJAAHHvGcJlj+0x7i1OWLZmIpn4zT3X3grtEFxmT O3MpGWjyIVSkppK4i+gsm2HtX/l3Iu22F8xLU7B+Wi50fgp5bWPZl2yFg9eXlFU/3YHn TgvSbAuJX45BM8mjy7mFXLhTWAyn7VAY6u59fwO1ujly1FY1pMwDP584A+/FyMkFPiJW f3trcBUlur1eztTx0U4KcL/E+FqnKt0TNRT1n067GAcv/Fnf6tab1KQc/LC7pLeTl7C8 nUAQjLn8PbtX+5iGd9js4s4e//LMKJ8Fta4YcVRKrK+fwc/OtviFGmGxmhseovGpkh0a NICg== X-Received: by 10.60.102.74 with SMTP id fm10mr8232302oeb.65.1436711225598; Sun, 12 Jul 2015 07:27:05 -0700 (PDT) X-Mailer: git-send-email 2.1.0 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 54 Organization: linux.* mail to news gateway X-Original-Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Tony Lindgren , linux-omap@vger.kernel.org X-Original-Date: Sun, 12 Jul 2015 09:26:45 -0500 X-Original-Message-ID: <1436711211-18223-8-git-send-email-robh@kernel.org> X-Original-References: <1436711211-18223-1-git-send-email-robh@kernel.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: aioe.org linux.kernel:1182358 set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID -> !IRQ_NOREQUEST IRQF_PROBE -> !IRQ_NOPROBE IRQF_NOAUTOEN -> IRQ_NOAUTOEN For IRQs managed by an irqdomain, the irqdomain core code handles clearing and setting IRQ_NOREQUEST already, so there is no need to do this in .map() functions and we can simply remove the set_irq_flags calls. Some users also set IRQ_NOPROBE and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Acked-by: Roger Quadros Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org --- drivers/memory/omap-gpmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 8911e51..dde6f4dd 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -1176,8 +1176,8 @@ static int gpmc_setup_irq(void) gpmc_client_irq[i].irq = gpmc_irq_start + i; irq_set_chip_and_handler(gpmc_client_irq[i].irq, &gpmc_irq_chip, handle_simple_irq); - set_irq_flags(gpmc_client_irq[i].irq, - IRQF_VALID | IRQF_NOAUTOEN); + irq_modify_status(gpmc_client_irq[i].irq, IRQ_NOREQUEST, + IRQ_NOAUTOEN); } /* Disable interrupts */ @@ -1200,7 +1200,6 @@ static int gpmc_free_irq(void) for (i = 0; i < GPMC_NR_IRQ; i++) { irq_set_handler(gpmc_client_irq[i].irq, NULL); irq_set_chip(gpmc_client_irq[i].irq, &no_irq_chip); - irq_modify_status(gpmc_client_irq[i].irq, 0, 0); } irq_free_descs(gpmc_irq_start, GPMC_NR_IRQ); -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/