Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Ulf Magnusson <ulfalizer.lkml@gmail.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH 1/2] kconfig: also warn of unhandled characters in statements
Date: Sun, 05 Jul 2015 10:50:01 +0200
Message-ID: <pINMB-Ad-7@gated-at.bofh.it>
References: <pI8zL-7J-7@gated-at.bofh.it> <pI8zM-7J-15@gated-at.bofh.it> <pINMB-Ad-9@gated-at.bofh.it>
X-Original-To: Paul Bolle <pebolle@tiscali.nl>
Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=By0ZKZ9Rq+R3CZw94M8TB2843zurrfdiE6GeXJ70SeM=; b=zLe85J+G7TyvuY1B05JCHTQrWtn9H78GI8g3f9967PiJ7FgqDAYx3aXIrCYAaFdWDT brqrmUpuhCWz3LoDFz26nxlFeFVq8i1Vm6QH1xmlmhEMpHhv2NxKMM1TGgvqFHqOPdN9 e+vK2plG3LKTd+nNBYKLrcgfKHefx+V6EsAQQrqKSAgziPUvADQ0KfXZ2TnSsSzO4t6H FbaolO5VmSVFNfKZOt0RxWv1q2OG4MHISgAe4YYUsmyzyaC7Z4BQ2ju0s7GlD78o1Z6e bcR7JjVFZPV6GyTTh64DuMjWAgOi1UEUX7e4GdkiGt+UVMeoSkI37EVqmUk2kQZ1WqKA kAHg==
MIME-Version: 1.0
X-Received: by 10.202.243.215 with SMTP id r206mr37344408oih.106.1436078681288; Sat, 04 Jul 2015 23:44:41 -0700 (PDT)
Content-Type: text/plain; charset=UTF-8
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 24
Organization: linux.* mail to news gateway
X-Original-Cc: Andreas Ruprecht <andreas.ruprecht@fau.de>, Valentin Rothberg <valentinrothberg@gmail.com>, rafael.j.wysocki@intel.com, "open list:KCONFIG" <linux-kbuild@vger.kernel.org>, Kernel Mailing List <linux-kernel@vger.kernel.org>, hengelein Stefan <stefan.hengelein@fau.de>, linux@dominikbrodowski.net, Michal Marek <mmarek@suse.cz>
X-Original-Date: Sun, 5 Jul 2015 08:44:41 +0200
X-Original-Message-ID: <CAEMqcmpnL58MpscBgs6YmrhTeVUKeHDhox2hWJ6wyX9ks=PHYA@mail.gmail.com>
X-Original-References: <cover.1435927467.git.andreas.ruprecht@fau.de> <a2424e6c57a4d6c38369c393ba58e0d050b7c130.1435927467.git.andreas.ruprecht@fau.de> <1436002433.20057.49.camel@tiscali.nl>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: aioe.org linux.kernel:1176879

On Sat, Jul 4, 2015 at 11:33 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On vr, 2015-07-03 at 14:46 +0200, Andreas Ruprecht wrote:
>> While commit 2e0d737fc76f ("kconfig: don't silently ignore unhandled
>> characters") introduced a warning for unsupported characters inside
>> parameters,
>
> What are "parameters"? The term doesn't show up in Documentation/kbuild.
>

zconf.l parses each line like "<COMMAND> <PARAM> <PARAM> ...", with a slightly
different set of characters allowed for <COMMAND> and <PARAM> (for whatever
reason). I agree that that's not clear from the commit message alone though.

(As a side note, that Flex/gperf split seems kinda odd to me. Does anyone know
of a good reason why more lexing wasn't done in zconf.l? Is it an optimization
attempt?)

Cheers,
Ulf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/