Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt  clear method
Date: Thu, 25 Jun 2015 08:10:02 +0200
Message-ID: <pF8wi-eR-5@gated-at.bofh.it>
References: <pEPah-5K1-7@gated-at.bofh.it> <pEPah-5K1-19@gated-at.bofh.it> <pF2TU-d1-3@gated-at.bofh.it> <pF7Tz-7G3-3@gated-at.bofh.it> <pF83h-7TJ-11@gated-at.bofh.it> <pF8cW-851-1@gated-at.bofh.it> <pF8mB-8fX-3@gated-at.bofh.it> <pF8mC-8fX-5@gated-at.bofh.it>
X-Original-To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
X-Auditid: cbfec7f5-f794b6d000001495-a8-558b9a2cb580
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xq7o6s7pDDR79kLeYf+Qcq8XrF4YW 978eZbTY9Pgaq8XlXXPYLFr3HmG3uH51I4vFri/PGR04PDat6mTzuHNtD5vH5iX1HpMXXmT2 6NuyitHj8ya5ALYoLpuU1JzMstQifbsErow3F6eyFkwWqvjyZxJbA+NV3i5GTg4JAROJTSvu sEDYYhIX7q1nA7GFBJYySszeaNHFyAVkP2WUeH70OFiCV0BLovfgb2YQm0VAVeLvhOVMIDab gLHE5uVLwGpEBSIk3l4+yQRRLyjxY/I9sAUiAkYSp3vXsoPYzAJrGSX2nVQBsYUFIiV6Hh1g hFj2jkli9uRzrCAJTqBlh9Y3AzVwADWoS0yZkgvRKy+xec1b5gmMArOQrJiFUDULSdUCRuZV jKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCEh/3UH49JjVocYBTgYlXh4K2y7Q4VYE8uKK3MP MUpwMCuJ8DYGAIV4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TB KdXAuO/nggd2WzaqvHt+RsbKLujBK6c5ugfO1WeKZ555YspwfXrz+vfXlyqFOa9p3nBGoIWj tUlPefvmtT4ZmjIrOQXXqL4MzO06efTdDPnmr7kpUrtMAioa99npHpC5IpbdEcyzj4u115Ep 59D/IyfOW/Kcv7ai/px1KuMZTuv91dYbQ0z6L7JHKrEUZyQaajEXFScCAOv2Q4l1AgAA
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 80
Organization: linux.* mail to news gateway
X-Original-Cc: linux-arm-kernel@lists.infradead.org, Zhao Ye <zhaoy@marvell.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lee.jones@linaro.org
X-Original-Date: Thu, 25 Jun 2015 15:05:34 +0900
X-Original-Message-ID: <558B9A2E.4020009@samsung.com>
X-Original-References: <1435137673-1629-1-git-send-email-vaibhav.hiremath@linaro.org> <1435137673-1629-3-git-send-email-vaibhav.hiremath@linaro.org> <CAJKOXPdqTnkB6Lw4fsJ-=o4=QcYcAtZK0zgOM9aqgesTU=Dw+A@mail.gmail.com> <558B90F7.80700@linaro.org> <558B9272.6090100@samsung.com> <558B9549.5010705@linaro.org> <558B96B7.3030501@samsung.com> <558B984D.9040309@linaro.org>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: aioe.org linux.kernel:1171866

On 25.06.2015 14:57, Vaibhav Hiremath wrote:
> 
> 
> On Thursday 25 June 2015 11:20 AM, Krzysztof Kozlowski wrote:
>> On 25.06.2015 14:44, Vaibhav Hiremath wrote:
>>>
>>>
>>> On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote:
>>>> On 25.06.2015 14:26, Vaibhav Hiremath wrote:
>>>>>
>>>>>
>>>>> On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote:
>>>>>> 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath
>>>>>> <vaibhav.hiremath@linaro.org>:
>>>>>>> As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
>>>>>>> (page 0) controls the method of clearing interrupt
>>>>>>> status of 88pm800 family of devices;
>>>>>>>
>>>>>>>      0: clear on read
>>>>>>>      1: clear on write
>>>>>>>
>>>>>>> This patch allows to configure this field, through DT.
>>>>>>>
>>>>>>> Also, as suggested by "Lee Jones" renaming DT property and variable
>>>>>>> field to appropriate name.
>>>>>>>
>>>>>>> Signed-off-by: Zhao Ye <zhaoy@marvell.com>
>>>>>>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>>>>>>
>>>>
> 
> <snip>
> 
>>>
>>> Yes,
>>> Fair enough...
>>>
>>> I see very little value in runtime configuration, why not just do it
>>> only way (either read or write)?
>>> I would prefer to just set it by default (during init), to clear irq on
>>> write.
>>
>> Hard-coding a default value, if board files are not present, looks OK
>> to me.
>>
> 
> This is how it will look, I will also update the binding information
> with this.
> 
> 
> hvaibhav@hvaibhav-ThinkPad-T440p:~/projects/mainline/linux$ git diff
> --cached
> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
> index 0a417ac..e415a06 100644
> --- a/drivers/mfd/88pm800.c
> +++ b/drivers/mfd/88pm800.c
> @@ -645,9 +645,8 @@ static int pm800_probe(struct i2c_client *client,
>                         dev_err(&client->dev, "failed to allocaate
> memory\n");
>                         return -ENOMEM;
>                 }
> -
> -               pdata->irq_clr_on_wr = of_property_read_bool(np,
> -                                       "marvell,irq-clr-on-write");
> +               /* Setting irq clear method on write */
> +               pdata->irq_clr_on_wr = true;
>         }
> 
>         ret = pm80x_init(client);

IMHO it is good.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/