Path: csiph.com!aioe.org!news.lightlink.com!eternal-september.org!feeder.eternal-september.org!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod From: Tejun Heo Newsgroups: linux.kernel Subject: [PATCH 1/7] blkcg: remove unnecessary request_list->blkg NULL test in blk_put_rl() Date: Wed, 24 Jun 2015 04:50:03 +0200 Message-ID: References: X-Original-To: axboe@kernel.dk Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=M6jP2XSVrkSHxEPy5dc7/sCi/e+rA6uVkbv4m/EoD/8=; b=0MHAKG5ghybWGLQwUhTPBlAuN2tGp9LAnM5DH8j/hPQ71Wghetwji6kMXZGcQUQa2m XDGZzdvKhMH9mZnsEeZkZC+9JievU2VQ6rp1pnyiki5aaIB9PGLP18RMyN+XTnKPthXY GtMEODbITSLusWYZLSnUrtvCOUFdu787mnNWT4j/F4DjXUW97CKw02j+sv528E2/Ee/N VvLliaWg28TSvmX/YWrJPfkXkGOARB2jcOyhOyaCycyoVVqRx1NaBDbFABNJt1NBtTzY JA92+6eoLigmBQ3zMmD5YpLbtKISdTFO6tnn+MTt25yfdVSIQPT7W9xW/3IF3HuEWbyN vPZg== X-Received: by 10.55.23.23 with SMTP id i23mr81440952qkh.23.1435113858175; Tue, 23 Jun 2015 19:44:18 -0700 (PDT) X-Mailer: git-send-email 2.4.3 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 32 Organization: linux.* mail to news gateway X-Original-Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, vgoyal@redhat.com, avanzini.arianna@gmail.com, kernel-team@fb.com, Tejun Heo X-Original-Date: Tue, 23 Jun 2015 22:44:07 -0400 X-Original-Message-ID: <1435113853-12053-2-git-send-email-tj@kernel.org> X-Original-References: <1435113853-12053-1-git-send-email-tj@kernel.org> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: aioe.org linux.kernel:1171043 Since ec13b1d6f0a0 ("blkcg: always create the blkcg_gq for the root blkcg"), a request_list always has its blkg associated. Drop unnecessary rl->blkg NULL test from blk_put_rl(). Signed-off-by: Tejun Heo Cc: Vivek Goyal --- include/linux/blk-cgroup.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index 07a32b8..50d1009 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h @@ -378,8 +378,7 @@ static inline struct request_list *blk_get_rl(struct request_queue *q, */ static inline void blk_put_rl(struct request_list *rl) { - /* root_rl may not have blkg set */ - if (rl->blkg && rl->blkg->blkcg != &blkcg_root) + if (rl->blkg->blkcg != &blkcg_root) blkg_put(rl->blkg); } -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/