Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Willy Tarreau Newsgroups: linux.kernel Subject: Re: [PATCH 3.10 14/46] d_walk() might skip too much Date: Sat, 13 Jun 2015 19:20:01 +0200 Message-ID: References: X-Original-To: Jari Ruusu MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 38 Organization: linux.* mail to news gateway X-Original-Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Al Viro X-Original-Date: Sat, 13 Jun 2015 19:11:18 +0200 X-Original-Message-ID: <20150613171118.GB13001@1wt.eu> X-Original-References: X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: aioe.org linux.kernel:1164664 Hi Jari, On Sat, Jun 13, 2015 at 07:01:31PM +0300, Jari Ruusu wrote: > When Al Viro's VFS deadlock fix "deal with deadlock in d_walk()" was > backported to 3.10.y 3.4.y and 3.2.y stable kernel brances, the deadlock fix > was copied to 3 different places. Later, a bug in that code was discovered. > Al Viro's fix involved fixing only one part of code in mainline kernel. That > fix is called "d_walk() might skip too much". > > 3.10.y 3.4.y and 3.2.y stable kernel brances need that later fix copied to 3 > different places. Greg Kroah-Hartman included Al Viro's "d_walk() might skip > too much" fix only once in 3.10.80 kernel, leaving 2 more places without a > fix. > > The patch below was not written by me. I only applied Al Viro's "d_walk() > might skip too much" fix 2 more times to 3.10.80 kernel, and cheched that > the fixes went to correct places. With this patch applied, all 3 places that > I am aware of 3.10.y stable branch are now fixed. > > Signed-off-by: Jari Ruusu Next time, please don't forget to mention the mainline commit IDs in addition to the message subjects, it helps a lot. The IDs from the stable branches are less important since it's generally quite easy to find them thanks to the mainline ID which appears in the message. Just for reference : - ca5358e ("deal with deadlock in d_walk()") - 2159184 ("d_walk() might skip too much") Thanks, Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/