Path: csiph.com!news.dns-netz.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From: =?utf-8?B?RsOpbGl4?= Sipma <felix+debian@gueux.org>
Newsgroups: linux.debian.maint.python
Subject: Re: package_data in python package
Date: Mon, 28 Oct 2019 16:30:02 +0100
Message-ID: <yWf7Y-3pc-11@gated-at.bofh.it>
References: <yWelz-2Sv-7@gated-at.bofh.it> <yWevf-2Wb-5@gated-at.bofh.it> <yWeOB-3is-7@gated-at.bofh.it> <yWeYi-3m0-1@gated-at.bofh.it>
Old-Return-Path: <felix+debian@gueux.org>
Mail-Followup-To: Scott Kitterman <debian@kitterman.com>, debian-python@lists.debian.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e6iw3mojobg5nwge"
Content-Disposition: inline
User-Agent: NeoMutt/20180716
Approved: robomod@news.nic.it
Lines: 100
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
Xref: csiph.com linux.debian.maint.python:11962


--e6iw3mojobg5nwge
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2019-10-28 11:15-0400, Scott Kitterman wrote:
> On Monday, October 28, 2019 11:02:40 AM EDT F=C3=A9lix Sipma wrote:
>> On 2019-10-28 10:44-0400, Scott Kitterman wrote:
>>> It's the way setuptools works.  Looking at the current upstream
>>> recommendations:
>>>=20
>>> https://python-packaging.readthedocs.io/en/latest/non-code-files.html
>>>=20
>>> your solution seems correct.
>>=20
>> Hi Scott,
>>=20
>> Thanks for your message. I'm not sure I get why upstream can't reproduce
>> the problem in this case... setuptools, as used in the setup.py seems to
>> install the data dir just fine, and without my patch.
>>=20
>> That's why I thought that it was maybe a limitation of dh-python...
>=20
> It does depend considerably on how you do the install.  For example, to=
=20
> replicate what pip does (to get the data files installed) you have to do:
>=20
> python setup.py install --single-version-externally-managed --record=3D/d=
ev/null
>=20
> I don't find I need to do that with pybuild though.  I find setuptools ha=
ndling=20
> of data files highly mysterious and counter-intuitive, so I doubt I'll ha=
ve=20
> more specific advice.
>=20
> Scott K

They just run "python3 setup.py install" (https://github.com/scheibler/khar=
d/issues/231):

    $ python3 -m venv test-for-231
    $ source test-for-231/bin/activate
    $ python3 setup.py install
    $ tree test-for-231/lib/python3.7/site-packages/khard-0.15.0-py3.7.egg
    test-for-231/lib/python3.7/site-packages/khard-0.15.0-py3.7.egg
    =E2=94=9C=E2=94=80=E2=94=80 EGG-INFO
    =E2=94=82   =E2=94=9C=E2=94=80=E2=94=80 dependency_links.txt
    =E2=94=82   =E2=94=9C=E2=94=80=E2=94=80 entry_points.txt
    =E2=94=82   =E2=94=9C=E2=94=80=E2=94=80 not-zip-safe
    =E2=94=82   =E2=94=9C=E2=94=80=E2=94=80 PKG-INFO
    =E2=94=82   =E2=94=9C=E2=94=80=E2=94=80 requires.txt
    =E2=94=82   =E2=94=9C=E2=94=80=E2=94=80 SOURCES.txt
    =E2=94=82   =E2=94=94=E2=94=80=E2=94=80 top_level.txt
    =E2=94=94=E2=94=80=E2=94=80 khard
        =E2=94=9C=E2=94=80=E2=94=80 actions.py
        =E2=94=9C=E2=94=80=E2=94=80 address_book.py
        =E2=94=9C=E2=94=80=E2=94=80 carddav_object.py
        =E2=94=9C=E2=94=80=E2=94=80 cli.py
        =E2=94=9C=E2=94=80=E2=94=80 config.py
        =E2=94=9C=E2=94=80=E2=94=80 data
        =E2=94=82   =E2=94=9C=E2=94=80=E2=94=80 config.spec
        =E2=94=82   =E2=94=94=E2=94=80=E2=94=80 template.yaml
        =E2=94=9C=E2=94=80=E2=94=80 helpers.py
        =E2=94=9C=E2=94=80=E2=94=80 __init__.py
        =E2=94=9C=E2=94=80=E2=94=80 khard.py
        =E2=94=9C=E2=94=80=E2=94=80 __main__.py
        =E2=94=9C=E2=94=80=E2=94=80 object_type.py
        =E2=94=94=E2=94=80=E2=94=80 version.py
   =20
    3 directories, 20 files

For my part, I "just" build the debian package with "gbp buildpackage",
and with "dh $@ --with python3 --buildsystem=3Dpybuild" in debian/rules.

The solutions I say are: I can keep the patch in the package (without
really understanding the need for it) or try to convince upstream to
merge it (but they can't reproduce the problem, so why would they do
that?). In both cases, probably others will encounter the same problem
in other packages... It would be nice to fix the problem once for all
(if possible :)).

Regards,

--=20
F=C3=A9lix

--e6iw3mojobg5nwge
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQR6zeIsS8L0XLQfqiQBpfxHUdFE8AUCXbcJKQAKCRABpfxHUdFE
8FDHAP9e3xyHf9lWhXxuXrKVXZskwADHRYMS+IDJKar5Porg7QD8DDmzFaxyYpLm
6ymQly0DsIvG2I9u8KVuREhKnoGm2wE=
=Xq0l
-----END PGP SIGNATURE-----

--e6iw3mojobg5nwge--