Path: csiph.com!news.dns-netz.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From: Andreas Tille <tille@debian.org>
Newsgroups: linux.debian.bugs.dist,linux.debian.maint.python
Subject: Bug#939181: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye
Date: Thu, 12 Sep 2019 09:30:03 +0200
Message-ID: <yFryx-2BZ-1@gated-at.bofh.it>
References: <yBKT7-8wu-11@gated-at.bofh.it> <yFaem-7xs-3@gated-at.bofh.it> <yFbDr-ee-7@gated-at.bofh.it> <yFbWN-lQ-9@gated-at.bofh.it> <yBKT7-8wu-11@gated-at.bofh.it> <yFbWN-lQ-9@gated-at.bofh.it>
X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org  Thu Sep 12 07:21:10 2019
Old-Return-Path: <debbugs@buxtehude.debian.org>
X-Spam-Flag: NO
X-Spam-Score: -4.2
Reply-To: Andreas Tille <tille@debian.org>, 939181@bugs.debian.org
Resent-To: debian-bugs-dist@lists.debian.org
Resent-Cc: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
X-Debian-Pr-Message: followup 939181
X-Debian-Pr-Package: src:cycle
X-Debian-Pr-Keywords: help sid bullseye
X-Debian-Pr-Source: cycle
X-Spam-Bayes: score:0.0000 Tokens: new, 8; hammy, 150; neutral, 55; spammy, 0. spammytokens: hammytokens:0.000-+--python3, 0.000-+--sk:salsad, 0.000-+--sk:salsa.d, 0.000-+--UD:salsa.debian.org, 0.000-+--salsa.debian.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: NeoMutt/20170113 (1.7.2)
X-Debian-Message: from BTS
X-Mailing-List: <debian-bugs-dist@lists.debian.org> archive/latest/1558156
List-ID: <debian-bugs-dist.lists.debian.org>
List-URL: <https://lists.debian.org/debian-bugs-dist/>
Approved: robomod@news.nic.it
Lines: 54
Organization: linux.* mail to news gateway
Sender: robomod@news.nic.it
X-Original-Cc: Antonio Terceiro <terceiro@debian.org>, 939181@bugs.debian.org, debian-python@lists.debian.org
X-Original-Date: Thu, 12 Sep 2019 09:17:08 +0200
X-Original-Message-ID: <20190912071708.5olnqppyshvtus2n@an3as.eu>
X-Original-References: <alpine.DEB.2.21.1909012302200.30297@bear.techie.net> <20190911123354.GA16873@debian.org> <20190911141234.7hwnsil5bp2m6cew@an3as.eu> <20190911143233.GC1706@belkar.wrar.name> <alpine.DEB.2.21.1909012302200.30297@bear.techie.net> <20190911143233.GC1706@belkar.wrar.name>
Xref: csiph.com linux.debian.bugs.dist:974787 linux.debian.maint.python:11789

Hi Andrey,

On Wed, Sep 11, 2019 at 07:32:33PM +0500, Andrey Rahmatullin wrote:
> > $ cycle
> > Traceback (most recent call last):
> >   File "/usr/bin/cycle", line 12, in <module>
> >     from dialogs import *
> >   File "/usr/share/cycle/dialogs.py", line 8, in <module>
> >     from cal_year import cycle, Val
> >   File "/usr/share/cycle/cal_year.py", line 9, in <module>
> >     from dialogs import Note_Dlg
> > ImportError: cannot import name 'Note_Dlg' from 'dialogs' (/usr/share/cycle/dialogs.py)
> There are circular imports in the code so you most likely broke that by
> reordering imports in various files.

s/you most likely broke/2to3 most likely broke/

I admit I did not really checked what 2to3 created but I can assure you
I did not simply fired up an editor and had fun reverting some import
sequences.

> "from cal_year import *; from dialogs import *" works, the reverse
> doesn't, so the /usr/bin/cycle code is definitely problematic, not sure
> about other changes.

I can not confirm that

   from cal_year import *

works at all.  It works in the unpatched Python2 version.

   git clone https://salsa.debian.org/med-team/cycle
   cd cycle
   echo "from cal_year import *" | python
   quilt push -a
   echo "from cal_year import *" | python3
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/andreas/debian-maintain/salsa/med-team/cycle/cal_year.py", line 9, in <module>
    from dialogs import Note_Dlg
  File "/home/andreas/debian-maintain/salsa/med-team/cycle/dialogs.py", line 12, in <module>
    from cal_year import cycle, Val
ImportError: cannot import name 'cycle' from 'cal_year' (/home/andreas/debian-maintain/salsa/med-team/cycle/cal_year.py)


So may be I misinterpreted your hint but even reverting the reordering
of 2to3 in my latest commit does not help.

Kind regards

      Andreas.

-- 
http://fam-tille.de