Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Michael Kesper Newsgroups: linux.debian.maint.python Subject: Re: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye Date: Thu, 12 Sep 2019 21:10:01 +0200 Message-ID: References: X-Original-To: debian-python@lists.debian.org X-Mailbox-Line: From debian-python-request@lists.debian.org Thu Sep 12 19:09:17 2019 Old-Return-Path: X-Amavis-Spam-Status: No, score=-8.04 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, LDO_WHITELIST=-5, MEDS2=2, PGPSIGNATURE=-5, RCVD_IN_DNSWL_LOW=-0.7, SARE_MLH_Stock10=1.66] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5.5 Openpgp: preference=signencrypt Autocrypt: addr=mkesper@schokokeks.org; prefer-encrypt=mutual; keydata= mQGiBEAc3nYRBAD+2hjAskx42DicUcKuvQy1QuCBez7pxhAiUES5JLb/SwcfRhlJIWgfgsSn x0euO8IP+eKp0+V3BSAKUWKYqKboDBzYNdxsI764KnbzBNJI6pxh9KVKlbsSxT1E1Bfp7tyl fQqG8IjTCIywtf2GWRKMrWFmTE0hOOBoaOU67LmdUwCgpdWIWPYgfWYojqItIkFCBLZwa1ED /iAiXKyVQgm4vOmbe9J6NzDsEaK2udPONHgcV5ckunUmdfocuSpFKhedlJ/+y5v2DuKZIWpJ /ASqVACbADBdzj0ogDokkeIUJLBIIjGwtgctTGZNXM5crHomU9BInMVXS4E+R7wr3WIfMsd7 D5216uq1bj2pCDIJWSoDc/cvMaZJA/4zPZL8n1Q0z2DJ9EfO9KvAK6Y6WSpEk60JDkuf9Sq/ krNbaIj1prViZaBE4cjawCo6lCI5jopROCFXudnphUY2A3RxT7ol6pRcEIjgd87Ro+q7TGUT 059nf5KCf9NGMcy2hx9p8O2tBy9SoITejdy0kjaA42G7HZ2/rdsXLNtHf7QnTWljaGFlbCBL ZXNwZXIgPG1rZXNwZXJAc2Nob2tva2Vrcy5vcmc+iGIEExECACIFAlXTjVcCGyMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAAAoJEEIIBcaJB0+tdjMAnR4dEcLKWTTreyyGAwARi2gyzDJ2 AKCXjb6yVzD/pzdRctgg+hC5+B9SybiLBES73PoBBACxm5+NGh2A5fiYezIUwcIUM1+J1M/D hWsDeoXtstuLpb0C+ZI9xjrKj4e7GxeblPxfAjznkL4SjITzINahFsUgsIXVtAgb3B2gd302 e8jSHln9zv9RbVOljwVOnO8NaQhU6fHdGacQBXoFt2VyaNJkoLyJuE1C6OlJuXMvdhyKeQAG KYjmBBgRAgAJBQJEu9z6AhsCAKgJEEIIBcaJB0+tnSAEGQECAAYFAkS73PoACgkQc5ivf1WD EDBbpwQAkm4tjp+HPF8uxtbg4rxaAfzNasaD+adLrXBDdUj+v6s4i3v4cbMhBjcA3wI9iNP7 jcc6+D2/QJfnxQ2tLUNBjHpTEs6PiYYh9EDDY3N/vTh1FAPppiztSZC0ufatmNnHD7q22GVO d3DPSZavVC/OAd830tR32tcDm6TvOL01tpQ+ugCeLp6vwDfdv5hPOtAi01wzahTpIn8Aljqj Do6sDW8yonCtVQKyma7Waie5AQ0EQBzejBAEALp0hrMJeIMZ3FqLyKwVyAQf72kyiOG7ggNf uTBBrYnqg+m2xvaOFi0qU6C4Ucr3wYNf9UCGSE1g8Yet5BOC4XFjxDd9+mSyiDss3tId7hEm N9Bnm6gnOkxoVDp1OEt7fgqLiV6RHeL7CWoQJNE3XTpxdnGcp4j4HeQTuiY6CypLAAMGA/9D yJz8pgcqLLu4WOSvAzncgYg7XiB89tJ4ZINxwMZEalYkSrRnsovQIAZb9Shl6nv+8iJjLTWi K6xBkEp8Rv1ADJqPuFbrvw9I0elPYm4AqDiEl3dGkiyU+ZBY9xdln59dSK2Pyz4NlN6IgGM8 RQWlSgeJX6nnhxrokeBMtYNz3ohGBBgRAgAGBQJAHN6MAAoJEEIIBcaJB0+tlBoAoKNhh/AB 2lw21kW0GyttzgjBDqV6AKCiuCeKD3s0ObAEIPZt4n89TjAy7LkBDQRV05EMAQgAujRoAXhH Witvpg0BuzrdXaNjPgwQoTHVp47u6Ud+naP2tNSY0A0MLISbyKDUurjCiRifnYX2jx7PRzxR grpg8EoU5NZynWoRTP9D524IiQupXPDtSBrUGEkgAWPVb+2e5ZGyMAmKk+yCeLsihGy1WL+c 9auf5NE5lQV0ftmEx4J4TVSJ9igWSozLXTOik+JtN2jlk3fVBYkcw4CffK77HCnJVfFwwIDd z+AcZBZEh/TFyN776WzLbu0AiilrmKgOidFMmK/Oaovnql/l+ccbzhosKKhKtehnM0zQqMq/ 0OJHy3Mk5+jXZMeKfmZpK21WrjlaavGtMy0pqcGJKY59TwARAQABiEkEGBECAAkFAlXTkQwC GwwACgkQQggFxokHT62u5QCeNQJn0Odo+Kn1C+PAWOAySRFA9vIAoI+UU8fW62GkBtFVwqyp ZHabjgFUuQGNBFXTjuYBDAC0bnCN3PhdzHkRc2MtFr4/e0l0DOxI8cxIPs7rofWQIKL9Jkbp Amp9Vt6HMYfhrkpX+ou4i/a0A+3xJ3Qq6PsQ7bsi3Qz56BcJtWJToD8fkQ6KUPiXOYpouLcv WAzukl+psx+xPO6OFCss6kkksCY2geDIOw50fqKoNqIryod/jAQrqkogNeZWwBKBmZoaEUd4 V0bIVuO/0iwiXcDCgb2msRsb2/BYWh5XvUMLg0dWDiLWloPyHJhusOQLH02dg4VQPU40GoRg qbWmb+rWuyaalOQ7HCTUElGszI2GxksGbCvhMup8VlpivP5yzgFY/74Tw+kLYqiWRfFO8CIV VMGAvi5ZvhYlmQn7lt1tAgAiTXGHW7xuh1W6PJ0TLr+O7p22yjBGCxm/JNvHe4aDYqil7VyT R7cEn8+9OuFeA6l7F9yiQYx+nnbYWYkF0PznSvVMehV80pKY9VvFNcIR5Q95Xy0u8hoHnqm1 x7pC04gdb5OGUvZoN9gf+uTrJHbu9vcAEQEAAYkB6AQYEQIACQUCVdOO5gIbAgGpCRBCCAXG iQdPrcDdIAQZAQIABgUCVdOO5gAKCRBg0UcEw+MusFjtC/4zqNcVEwwlm2yA9J1ZiAeI8goE Vqy0mdLnVJNHzWsRZSFU4Y4B5TZsK2DK8eqne9y4yGBJGoVQE7Rwlekp3ptVaImrZcKVo2q/ Nci8H4WViYX1UlVBiB4vA4KVBjcBbLpO518xDI57MHkKmR5CKsposTf0JwdsxSBB8kXuTFlE qkoaQjo0ISnpyaBJOx5UYiSnOmctP6Dxm9LbrV/RmQISJ+qUp4Ha/U8c2Af7YiATCn6bPODC evBWBKyTvUdzkyCYhwICe8sOIW/nngq/jAlMjcu+3yLFwaUho24WuciOLotZQ03CFBif7MQ6 1AxnDLGCNi3ptzZnpRs1T8R012I9sD/0pMk84DMZo/TZflvFWtfsawtmYzCkKf0WAXcUwCQh L4yVtRfOEls2cL+FVzzhVLC6hcnQTcGOv/LoXmgBR19c64NEiRDulC+WHna+TRcePy1yzi50 2llEyY+YZv99i+g/+lTAb9/iwPgxxSaMJn2qzehp1djYIXPnmuVKVlOsdwCfTdqmK1MjUNFk AT7xTyqzhNgjISEAnjcaKMPSZ6ngaA+2ciQ9Jkl6PLRe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="=_zucker.schokokeks.org-22609-1568315343-0001-2" X-Mailing-List: archive/latest/17328 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/eda346de-9ea7-57c8-0639-963507054e28@schokokeks.org Approved: robomod@news.nic.it Lines: 118 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Date: Thu, 12 Sep 2019 21:08:04 +0200 X-Original-Message-ID: X-Original-References: <20190911123354.GA16873@debian.org> <20190911141234.7hwnsil5bp2m6cew@an3as.eu> <20190911143233.GC1706@belkar.wrar.name> <20190912071708.5olnqppyshvtus2n@an3as.eu> <20190912085732.GD1706@belkar.wrar.name> <20190912140906.wfagwtol4ljcinhz@an3as.eu> Xref: csiph.com linux.debian.maint.python:11803 This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_zucker.schokokeks.org-22609-1568315343-0001-2 Content-Type: multipart/mixed; boundary="JrkceXcjzOg6LUdd31zAyEHpbPlCflUUR"; protected-headers="v1" From: Michael Kesper To: debian-python@lists.debian.org Message-ID: Subject: Re: [Help] Re: Bug#939181: cycle: Python2 removal in sid/bullseye References: <20190911123354.GA16873@debian.org> <20190911141234.7hwnsil5bp2m6cew@an3as.eu> <20190911143233.GC1706@belkar.wrar.name> <20190912071708.5olnqppyshvtus2n@an3as.eu> <20190912085732.GD1706@belkar.wrar.name> <20190912140906.wfagwtol4ljcinhz@an3as.eu> In-Reply-To: <20190912140906.wfagwtol4ljcinhz@an3as.eu> --JrkceXcjzOg6LUdd31zAyEHpbPlCflUUR Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable Hi, On 12.09.19 16:09, Andreas Tille wrote: > May be some final helping hint could be how to fix leaving the=20 > program that leads to: >=20 >=20 > Traceback (most recent call last): File "/usr/bin/cycle", line 83, > in OnCloseWindow Save_Cycle(cycle.name, cycle.passwd, cycle.file) > File "/usr/share/cycle/save_load.py", line 27, in Save_Cycle=20 > m.update(passwd) TypeError: Unicode-objects must be encoded before=20 > hashing >=20 >=20 > I tried >=20 > m.update(passwd.encode()) >=20 > but this leads later to >=20 > Traceback (most recent call last): File "cycle.py", line 83, in=20 > OnCloseWindow Save_Cycle(cycle.name, cycle.passwd, cycle.file) File=20 > "/home/andreas/debian-maintain/salsa/med-team/cycle/save_load.py",=20 > line 46, in Save_Cycle tmp=3Drt.encrypt( 'Cycle'+pickle.dumps(objSave) = > ) TypeError: can only concatenate str (not "bytes") to str >=20 >=20 > Since I do not have much experience with hashlib I'd be happy if=20 > someone might be able to proof-read `def Save_Cycle` in=20 > save_load.py. This does not have anything to do with hashlib per se. It's just the usual mess of mixing bytestrings with strings. You often don't notice in Python2, it just introduces subtle bugs. Python3 is more strict here and doesn't allow it. Try this: tmp =3D rt.encrypt('Cycle{}'.format(pickle.dumps(objSave))) As an explanation: Python 3.7.3 (default, Apr 3 2019, 05:39:12) [GCC 8.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import pickle >>> s =3D 'abc123=C3=BC=C3=B6=C3=9F' >>> objSave =3D pickle.dumps(s) >>> objSave b'\x80\x03X\x0c\x00\x00\x00abc123\xc3\xbc\xc3\xb6\xc3\x9fq\x00.' >>> type(objSave) >>> print('Cycle'+pickle.dumps(objSave)) Traceback (most recent call last): File "", line 1, in TypeError: can only concatenate str (not "bytes") to str >>> print('Cycle{}'.format(pickle.dumps(objSave))) Cycleb'\x80\x03C\x16\x80\x03X\x0c\x00\x00\x00abc123\xc3\xbc\xc3\xb6\xc3\x= 9fq\x00.q\x00.' Best wishes Michael P.S.: The code is in a bad state regarding whitespace / indentation. This is critical to get right in Python (e.g. after a for there _has to_ be an indentation added, Python normally uses four spaces, no tabs). --JrkceXcjzOg6LUdd31zAyEHpbPlCflUUR-- --=_zucker.schokokeks.org-22609-1568315343-0001-2 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEpe7P9ZkJ20fmQgZ+YNFHBMPjLrAFAl16l5QACgkQYNFHBMPj LrBZIwv/SyyLrdEBuvTJ5tN73UPhvu6TrtU8zDl9ZjQcmHh7m9GYZe1sl7DvzOSc pmclRV+L9gR6GDm91Y7MFGhIfW+LG92u0nuTlq5Lkuc+qN3xp1q6cIuaZRvjfCx5 0PgiluPFkVgzZkSYlYd5ebYhKwbDLJqsvS40D1m78cEb301LT4cqxHHD7qiwY3WU RXllXUjjRidfi9tFq0osyhdiXuR011ggSUPg4sLzYgMAt+0uAKnjmMWvQI2UddxT sSR0S/oXBfrkpeMXWrFz7gZ0bCna61NIfSh+Kxb/Iri9mQw4OYgebtBkVFHYq77S Rj/lCSTqtCTuU6hpvG5H5UPZ3n69nSTc68v9MD4Wlgk9sCO9bO+p4pz0lqSGcu2O 3UBxACPyszFJsMdIoo4kygKGKfz7aLkMtxl0ZpwuJC+WJUcAsqm3uYWxdUvWbqfy GsIK//ejV+Yn0aG8nXvGMq+/BbIeYWDKAcI+0FaNNK9z0SEC+WHc3OT9y3dR+xpd zcWH3gOn =n2t6 -----END PGP SIGNATURE----- --=_zucker.schokokeks.org-22609-1568315343-0001-2--