Path: csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod From: Pierre-Elliott =?iso-8859-1?Q?B=E9cue?= Newsgroups: linux.debian.maint.python Subject: Re: RFS: mu-editor and yotta dependencies Date: Sun, 30 Dec 2018 03:20:01 +0100 Message-ID: References: X-Original-To: Nick Morrott X-Mailbox-Line: From debian-python-request@lists.debian.org Sun Dec 30 02:12:35 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.98 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, PGPSIGNATURE=-5] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate:hard: -5 X-Greylist: delayed 4252 seconds by postgrey-1.36 at bendel; Sun, 30 Dec 2018 02:12:24 UTC MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6sbzdewcg7xgnt5i" Content-Disposition: inline Organization: The Debian Project User-Agent: NeoMutt/20170113 (1.7.2) X-Mailing-List: archive/latest/16636 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20181230021220.yzx4qbprdna2krpe@crans.org Approved: robomod@news.nic.it Lines: 128 Sender: robomod@news.nic.it X-Original-Cc: debian-python X-Original-Date: Sun, 30 Dec 2018 03:12:20 +0100 X-Original-Message-ID: <20181230021220.yzx4qbprdna2krpe@crans.org> X-Original-References: <20181230010128.mvtkm32pgtw3olbp@crans.org> Xref: csiph.com linux.debian.maint.python:11185 --6sbzdewcg7xgnt5i Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Le dimanche 30 d=E9cembre 2018 =E0 02:01:28+0100, Pierre-Elliott B=E9cue a = =E9crit=A0: > [snip] ## python-project-generator-definitions: uploaded 1) I uploaded a bit fast. It's not a big issue but could you consider removing the explicit python3 dependencies from the binary package's Depends field? Normally debhelper finds the appropriate list from python3:depends meta-dependency, using install_requires field of setup.py. ## python-project-generator: 1) I wonder why you removed the alternative entry point. 2) Please remove all specific entries for the binary package Depends, except python3-project-generator-definitions (<< 0.3.0): python3:depends drags the others properly. I'll upload as soon as this is done, as the package builds properly and raises no lintian issue. ## valinor: 1) You should ask upstream to provide a changelog, even though your changelog.upstream.md is a perfectly fine temporary solution. 2) Same about the Depends field of this package, keep gdb of course, as no :depends entry will drag it. 3) d/watch: could you use version=3D4 here or is there an issue? 4) Is there a good reason for your export PYBUILD_AFTER_INSTALL=3Dmv {destdir}/usr/bin/valinor {destdir}/usr/share/valinor/run in d/rules plus the link for /usr/bin? Same as -project-generator, I'll upload as soon as you've answered these questions. It builds perfectly otherwise. ## python-mbed-ls: 1) Same as the others regarding the Depends field of the binary package. 2) For the Doxygen patch, you removed the genlatex, I guess it's because you don't want to drag texlive for the building part? I'm fine with this. I'll upload as soon as you've answered these questions. ## python-mbed-host-tests: 1) Same as the others regarding the Depends field, prospectively keeping the versioned dependencies I'll upload as soon as you've answered these questions. ## mbed-test-wrapper: 1) Still the same Depends question. :) keep binutils-arm-none-eabi, of course. I'll upload as soon as you've answered these questions. ## python-hgapi 1) You should suggest your patches to upstream. Uploaded. ## yotta 1) Same old Depends field. You must keep valinor and mbed-test-wrapper at least for now (I think that they'll be matched by the dh magic when they'll be in the archive). 2) I wonder why you added python3-openssl and python3-idna to the dependencies, they seem not needed according to setup.py? If you need them, please add them manualy to the Depends field as they won't be dragged by the python3:depends variable. In that case maybe it would be worth do att a README.source in the debian/ directory explaining why these packages are needed. If upstream forgot to add these dependencies, please notify them with a bug report. Summary: > > -> yotta: x > > -> python-hgapi: ./ > > -> mbed-test-wrapper: x > > -> python-mbed-host-tests: x > > -> python-mbed-ls: x > > -> valinor: x > > -> python-project-generator: x > > -> python-project-generator-definitions: ./ (!) The other packages will have to wait, I'd rather finish this batch first. As my remarks are more like nitpicking, I'd like to insist on the quality of your work. Those packages are really neat. Thanks for your great work! --=20 Pierre-Elliott B=E9cue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. --6sbzdewcg7xgnt5i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEESYqTBWsFJgT6y8ijKb+g0HkpCsoFAlwoKX8ACgkQKb+g0Hkp CsqIOw//dzMIMovfnMnE506w3qYVH9HEUk8BWtrgxE4uhfRsXw5tTksvomBAu7Yh xnZpn1LG7kZQKQepF85mSXoEe0XsOmF3mx6DdLr+nOyA1kKcYK2XgcY9UfOmOIyf ArEUdGaiOisgxjmtlLi1PgYs02rYhd4okAizYXFgEAQQZ4Fl4XcSWWA51zOcYBbe 0oDPEhi7lyFOW88F7tGHMU9HhcuaHvnI74J+miAltMdbCUuGKeUSXslCTtqvpoe0 eToUgecFJdZkZlWQcRhA7q2AlQH+adaTW/Y8gIX/f7pS2mpgW4xO2cQ6ggtGQGSw 82LZPUICDhgim55OfK5iUC3m+TGiQvFgtejs2Cx7cJHMd+bcR4hPdkpbEwtLbWx9 NyPmyNUMtd/2scPWvlbL3H+YvAmn3uhieFX2JxtXQe7AB7QqJHQxXyeD5xvSp+EN cTek7XdMYcFFM9EZTTiocLaW6vP80UdsQCR3LRcJIxXX+AU94Eu2Ndj+1yQeWvIH xPIxwarbFO01QfGDN6erhD9AzmAav2uOZQ7woyTzYcM3Fu3oBm13pxIfX4eqTEvH A0Og3aistT+P8pXc5yI7T3nJ/8ZyELsQsr+yp5SRAsFv5AEV4lBi5WeFgpnwRc38 05vm8McDukSlKJbz4J9zZhnxxh0CRcldjcH9d7a2RMIXU3tCC/k= =h42O -----END PGP SIGNATURE----- --6sbzdewcg7xgnt5i--