Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Pierre-Elliott =?iso-8859-1?Q?B=E9cue?= Newsgroups: linux.debian.maint.python Subject: Re: RFS: mu-editor and yotta dependencies Date: Sun, 30 Dec 2018 18:50:01 +0100 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Sun Dec 30 17:42:45 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-11.98 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5, MURPHY_DRUGS_REL8=0.02, PGPSIGNATURE=-5] autolearn=ham autolearn_force=no X-Policyd-Weight: using cached result; rate: -5 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ak6ctfvmxp22f2ms" Content-Disposition: inline Organization: The Debian Project User-Agent: NeoMutt/20170113 (1.7.2) X-Mailing-List: archive/latest/16641 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/20181230174231.ouclunno5cktymnk@crans.org Approved: robomod@news.nic.it Lines: 218 Sender: robomod@news.nic.it X-Original-Cc: debian-python X-Original-Date: Sun, 30 Dec 2018 18:42:31 +0100 X-Original-Message-ID: <20181230174231.ouclunno5cktymnk@crans.org> X-Original-References: <20181230010128.mvtkm32pgtw3olbp@crans.org> <20181230021220.yzx4qbprdna2krpe@crans.org> Xref: csiph.com linux.debian.maint.python:11190 --ak6ctfvmxp22f2ms Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Le dimanche 30 d=E9cembre 2018 =E0 05:14:34+0000, Nick Morrott a =E9crit=A0: > On Sun, 30 Dec 2018 at 02:12, Pierre-Elliott B=E9cue wro= te: > > > > Le dimanche 30 d=E9cembre 2018 =E0 02:01:28+0100, Pierre-Elliott B=E9cu= e a =E9crit : > > > [snip] > > > > ## python-project-generator-definitions: uploaded > > > > 1) I uploaded a bit fast. It's not a big issue but could you consider > > removing the explicit python3 dependencies from the binary package's > > Depends field? Normally debhelper finds the appropriate list from > > python3:depends meta-dependency, using install_requires field of > > setup.py. >=20 > Updated >=20 > > ## python-project-generator: > > > > 1) I wonder why you removed the alternative entry point. >=20 > I dropped it to be consistent with > python3-project-generator-definitions which only provides a single > entrypoint in the same "namespace". I also thought the longer > entrypoint name was somewhat cumbersome. >=20 > > 2) Please remove all specific entries for the binary package Depends, > > except python3-project-generator-definitions (<< 0.3.0): > > python3:depends drags the others properly. >=20 > Updated Uploaded, thanks! > > ## valinor: > > > > 1) You should ask upstream to provide a changelog, even though your > > changelog.upstream.md is a perfectly fine temporary solution. >=20 > https://github.com/ARMmbed/valinor/issues/29 >=20 > > 2) Same about the Depends field of this package, keep gdb of course, as > > no :depends entry will drag it. >=20 > Updated >=20 > > 3) d/watch: could you use version=3D4 here or is there an issue? >=20 > Bumped to version 4 (I had cribbed from another d/watch file using pypi) >=20 > > 4) Is there a good reason for your export PYBUILD_AFTER_INSTALL=3Dmv > > {destdir}/usr/bin/valinor {destdir}/usr/share/valinor/run in d/rules > > plus the link for /usr/bin? >=20 > The package build attempts to install the script "valinor" into > /usr/share/valinor/valinor/, which it can't because of the naming > conflict. This occurs in a few of the other packages too I think. Ack, I'm surprised by the mentioned behaviour but in any case, this choice you made isn't irrelevant so let's stick to it for now. If you find some time to investigate what causes such behaviour, please give me some feedback! > > ## python-mbed-ls: > > > > 1) Same as the others regarding the Depends field of the binary packag= e. >=20 > Updated >=20 > > 2) For the Doxygen patch, you removed the genlatex, I guess it's becau= se > > you don't want to drag texlive for the building part? I'm fine with > > this. >=20 > Yes I made a small mistake, you had to keep python3-pkg-resources and python3-colorlog here, but I forgot to mention them. I made a fixing commit. Uploaded. > > ## python-mbed-host-tests: > > > > 1) Same as the others regarding the Depends field, prospectively keepi= ng > > the versioned dependencies >=20 > Updated I restored python3-pkg-resources as a dependency. I missed that one. Uploaded. > > ## mbed-test-wrapper: > > > > 1) Still the same Depends question. :) keep binutils-arm-none-eabi, of > > course. >=20 > In this instance, the source setup.py file does not declare anything > in install_requires and so the dependencies must be added manually. >=20 > I've asked upstream to consider adding explicit dependencies for > mbed-ls and mbed-host-tests: >=20 > https://github.com/autopulated/mbed-test-wrapper/issues/3 Ack, my bad, I must've been a little tired, I missed the setup.py emptyness. Uploaded. > > ## python-hgapi > > > > 1) You should suggest your patches to upstream. >=20 > The patches were take from upstream's repository and links to the PRs > are in the patch headers. Ah, good to know! > > ## yotta > > > > 1) Same old Depends field. You must keep valinor and mbed-test-wrapper= at > > least for now (I think that they'll be matched by the dh magic when > > they'll be in the archive). >=20 > Updated >=20 > > 2) I wonder why you added python3-openssl and python3-idna to the > > dependencies, they seem not needed according to setup.py? If you ne= ed > > them, please add them manualy to the Depends field as they won't be > > dragged by the python3:depends variable. In that case maybe it woul= d be > > worth do att a README.source in the debian/ directory explaining why > > these packages are needed. If upstream forgot to add these dependen= cies, > > please notify them with a bug report. >=20 > I *think* I originally added them because they are suggested deps of > requests. I can't see anything in the source that suggests they are > needed, so I will drop them. Ack, and uploaded, too. > > Summary: > > > > > > -> yotta: x > > > > -> python-hgapi: ./ > > > > -> mbed-test-wrapper: x > > > > -> python-mbed-host-tests: x > > > > -> python-mbed-ls: x > > > > -> valinor: x > > > > -> python-project-generator: x > > > > -> python-project-generator-definitions: ./ (!) > > > > The other packages will have to wait, I'd rather finish this batch firs= t. >=20 > That's awesome. Thank you for the review. >=20 > I've pushed changes to salsa, (hopefully) addressing all of the above > issues. Please let me know if I've missed any or if any follow up is > required. I think it's all good now. Sorry for my own mistakes. Summary: all uploaded, some already got through new, the others should follow. I shall give some time to other python packages waiting for sponsorship, then I'll come back at you for the second batch. > > As my remarks are more like nitpicking, I'd like to insist on the quali= ty of > > your work. Those packages are really neat. > > > > Thanks for your great work! >=20 > Thanks for your kind words, You're very welcome. --=20 Pierre-Elliott B=E9cue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. --ak6ctfvmxp22f2ms Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEESYqTBWsFJgT6y8ijKb+g0HkpCsoFAlwpA4cACgkQKb+g0Hkp CsqEPg/9Fxfxy5ACaK47xns+sMdCAo8WvsFmu1QNfOlRRp9KO+B/tI4M6seli5km N4O2K57OdsZK89ZYjNcSAULows9Zde+b5wPXhbmDiKFDe0T1Bhg8ydsxXJWEBwtC Lpn9N733yQ7Plk6yiU4X4ManQHmCBvZnNRn4l/1pjj0YX+pvHokW6OkgCawRXQcd QnzwzfZA7BAsUrwyR0eJc21VO9sitaKrlwOOvYZz2zJgYzfUpm3WHzFBj23zK3Oe qSEzfe/94G44CqrzMdlXh0DSJSKs5xe3yr+CGa9uVQfCSUrpPBsm5ZwQlWNnxlAD OMhkqDUBnGjwLNoyd5pFo8XqT2zMafYDQDEdif9sRpANnYqsPuD7Zbl+5xGQ6iM6 KSFE1g1EBQt86G+bmUiKC9YnC7OESsrLRXWYiIIZ4JhVLjpThvGM4upsKnDoeiBk axDfdnjuR/Vk3vIpEYwpLqQl/zZpRuDJ4G+kKqDP+gXh5SkQisSjgE7hq4qTMnsc 2lIf3hkQW9lBbIYRXHIqGGY9qpgkhs/RlV/4IKf1nziGWltSwduJLo4ZDCEva9ao ZQqEbSMqu28NdADclnx1s0BbMQfEdktDe1z/Bi3KVmUI957KgaMeFe1gq75vWDvl A0kAhbpQdhUCH79WPY2AGl4JNGO5e0HOlepJbR4oKGjFliSWqKw= =cmBw -----END PGP SIGNATURE----- --ak6ctfvmxp22f2ms--