Path: csiph.com!news.mixmin.net!news.unit0.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod From: Sergio Durigan Junior Newsgroups: linux.debian.maint.python,linux.debian.devel.mentors Subject: Re: RFS: pcapy/0.11.3-1 [ITA] Date: Wed, 22 Aug 2018 07:00:02 +0200 Message-ID: References: X-Original-To: eamanu15 X-Mailbox-Line: From debian-python-request@lists.debian.org Wed Aug 22 04:59:27 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-12.179 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, LDO_WHITELIST=-5, MENTORSRFS=-0.3, MURPHY_DRUGS_REL8=0.02, PGPSIGNATURE=-5] autolearn=ham autolearn_force=no X-Policyd-Weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_FROM_MX=-3.1; rate: -6.1 X-URL: http://blog.sergiodj.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailing-List: archive/latest/16253 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/87h8jnxahu.fsf@sergiodj.net Approved: robomod@news.nic.it Lines: 129 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python , "python-modules-team\@lists.alioth.debian.org" , Debian Mentors List X-Original-Date: Wed, 22 Aug 2018 00:59:09 -0400 X-Original-Message-ID: <87h8jnxahu.fsf@sergiodj.net> X-Original-References: <87k1qywmgp.fsf@debian.org> <87bma9a1g5.fsf@sergiodj.net> <87zhxh98ut.fsf@sergiodj.net> Xref: csiph.com linux.debian.maint.python:10832 linux.debian.devel.mentors:41592 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Emmanuel, Sorry, you still have to fix a few things before the package is ready for upload. We're almost there; don't give up! On Tuesday, August 21 2018, eamanu wrote: > No problem. However, the "License:" still doesn't reflect the license >> of the software. According to LICENSE: >> >> We provide this software under a slightly modified version of the >> Apache Software License. The only changes to the document were the >> replacement of "Apache" with "Pcapy" and "Apache Software Foundation" >> with "CORE Security Technologies". Feel free to compare the resulting >> document to the official Apache license. >> >> The `Apache Software License' is an Open Source Initiative Approved >> License. >> >> Therefore, I think a better value for the field would be: >> >> License: Apache with Pcapy modifications >> > > Ready! Thanks. The "License:" must be the same in both places, though. Here: Files: * Copyright (C) 2014 CORE Security Technologies .=20 License: Apache Software License with Pcapy modifications and here: License: Apache with Pcapy modifications We provide this software under a slightly modified version of the ... It's OK to use "Apache with Pcapy modifications" in both places. >> I see that the contributions under the debian/ directory are released >> under GPL-3+. That's absolutely fine (I am a GPL advocate as well). >> However, I must warn you that the Debian patches will also be released >> under this license, which may be problematic if/when you decide to >> upstream them. But I understand this is the current situation anyway. >> You may want to try to contact Arnaud Fontaine and ask him if he's OK >> with changing the license to Apache in the future. >> > > Ok. I will contact Arnaud Fontaine to ask about it. I think it's ok for > now. In the next release of package I can update this field. Great. It's OK for now, indeed. > Thanks, but what you did is incomplete. In order to create a new >> package, you have to create an entry for it on d/control. What you did >> (add ${python3:Depends} to python-pcapy's Depends) is wrong because >> you're basically pulling Python 3 dependencies for a Python 2 package. >> Please have a look at other packages under them DPMT and check their >> d/control; you will find many examples of how to create Python 3 >> packages. >> > > Ready! Thanks, that's better, but there are still a few things that need fixing. 1) It's a good practice to explicitly say if the package is a Python 2 or Python 3 module. We do that by suffixing the short description with "(Python X)" (where X is 2 or 2), and by appending "This package installs the library for Python X." to the long description. Like this: Package: python-pcapy Architecture: any Depends: ${python:Depends}, ${shlibs:Depends}, ${misc:Depends} Recommends: python-impacket Description: Python interface to the libpcap packet capture library (Pyth= on 2) Pcapy is a Python extension module that interfaces with the libpcap packet capture library. . Pcapy enables Python scripts to capture packets on the network. Pcapy is highly effective when used in conjunction with a packet-handling package such as Impacket, which is a collection of Python classes for constructing and dissecting network packets. . This package installs the library for Python 2. 2) You don't need to specify "Provides:". Please remove them from both packages. As a last note, it seems that you forgot to push the "upstream" and "pristine-tar" branches, so I can't really build the package locally here. Please do that. Thanks, =2D-=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEI3pUsQKHKL8A7zH00Ot2KGX8XjYFAlt87Z0ACgkQ0Ot2KGX8 XjbKXQ//WPiAhJYqu62qNhCZC2FP7j9So4Jz+6qeBoc5ns8ltcPWxHJrGgx3K/A+ FNyCph6qGHTTk2v3osh6FbyuRL5KSSG/ByLb6m2ZS3KOpz9DT1Zo+no82UTgt7do pYrQfhtbV5dP87YUiE/3mjQb3zas0JeL2A5z1cwXTxXllv73e04TXAzFE9bJecZe OsWWy9JPSMFxLGllectP68TCVAWUYF/7mPTLvjr8Cuu7UMVldY1Tvo+9ZpJAiF/A lQiasyiQdua88OI2BqEPXH8xpuv1+9kH8V5VCBrxOhmKq3wgo7Ld+c1jWPDSw6yZ eZ5hl+IHNy4F+UW94Vu40S0EgFmAqlG/gN5T5yrRBJVWjxTCNCwkqnGvhcLfR+Ih gO/MUnkTPd8yTVzHRoElYHagHGCIX/P9ewvIJtScKJk+9/8HGQ7AkTpzOlo+Jllk gC/G4BtDxkS1KQ+xEF5aUwwGL8FGNTqFpMNvRAaSXWAw63LSTaTnoS1kwcCKhx9E fhd5CmdB0yegwGX774ScEENK5tRRue0cEpKn7Djwiy/nCUOrO22ASf0cTNYBKvf+ sG+2CnsZiaeWp6UBpytl016+Nsd2bDH0pw3RZ1oJU1gj2wLca8iDcs9nZo88Iqel XqigKGtE/rofod+Vmp04pLDGdEk57CMWbw5+HSxBaO1B6RI2kEE= =F1+M -----END PGP SIGNATURE----- --=-=-=--