Path: csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: eamanu15 Newsgroups: linux.debian.maint.python,linux.debian.devel.mentors Subject: Re: RFS: pcapy/0.11.3-1 [ITA] Date: Wed, 22 Aug 2018 02:30:01 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Wed Aug 22 00:26:37 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-1.029 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, EMPTY_BODY=3, FOURLA=0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=2, LDO_WHITELIST=-5, MENTORSRFS=-0.3, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=no autolearn_force=no X-Policyd-Weight: DYN_NJABL=ERR(0) NOT_IN_SBL_XBL_SPAMHAUS=-1.5 BL_NJABL=ERR(-1.5) CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-vk0-x22d.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -7 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tC9oXTX6yao7IeH9KXfzKWH3F4nZhGSsqnAJLdyzhDY=; b=vdcFqkMhdTcFQHDdLBJHY7is52hIh76hLBlzZCMXV0fCumMfWusASFGOlphXqyuPSE rQQjOskylI2ehFhw4S8xLnyMoGSvehxEBLDP3yIV4Q0sx8LvcmkEfjr2XWvbt4jDXfTh HyWQh5kD9MxWKA1r6sREbHsX2B7oVGnHQddQyElsWaXp5LieZonxO6euHjT3y2ncIaGC 8Vlegld7EGDwqOnpbaaTDTQEYcVmR6fg8BIjsCzUS8xeT/slATaQlGHeyvMjYW1jFYMO FmUvoBhPb67Jrx7n3q8UoAuUV1ZL2rvDCXV7N9CtYps02N0njP6QmnimGIFOSqxKy01b /rmg== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tC9oXTX6yao7IeH9KXfzKWH3F4nZhGSsqnAJLdyzhDY=; b=f7vB3ubBZpHtj687SaTaklk4m4W0Q/d5bYi6OtBm06Dtx+mExjPAXTX+3rvScQ9SSm TmFLxNg1wkyjy1tmz0KQ84COdsizQ+gYvEQXre5l/obDoLCa97Hn6/bZ3q830vI0Hy7W dxrRVEr9euQIcELdSXG+bIkqFqHOUoqVCnzuj9a5gmtC1QCrEK1WGK/x35TTL8HOZW2a W3VCqWGLT1fcJONYLTo7NYGJh+A0FdhojhT2x2tY0OV6jSFm7+YEqPkapaOV7D79/hCD cqe25Bja1OZPn8BLEixuU8YtRQHAHNRa4ezuY8YP+2Bcku885Byd2k103KmeTzmFhsYu +UTQ== X-Gm-Message-State: AOUpUlFUiiv8JtxBqsRmq8rY7rWJ2bQvQiG42t7rtLdLDXRxD+W1LA9p zBlM6ESWMYK/UgUUigblEHJww28EmE14i/FYVWY= X-Google-SMTP-Source: AA+uWPxZr74+aULzN67nrC0EGJ06Zxhsw/wHEAs6v9ppLvhKoavFWTRrL5/OShcDloqcHQYO9YgyUL9RfKdilHTKL2U= X-Received: by 2002:a1f:7f1b:: with SMTP id o27-v6mr33793145vki.163.1534897567477; Tue, 21 Aug 2018 17:26:07 -0700 (PDT) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000046bc050573fb30a5" X-Mailing-List: archive/latest/16252 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CACttXDP14278KG_dx=BNPxvVuO+aO0MsAM8BwqWDZsHz8y_m+g@mail.gmail.com Approved: robomod@news.nic.it Lines: 153 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python , "python-modules-team@lists.alioth.debian.org" , Debian Mentors List X-Original-Date: Tue, 21 Aug 2018 21:25:54 -0300 X-Original-Message-ID: X-Original-References: <87k1qywmgp.fsf@debian.org> <87bma9a1g5.fsf@sergiodj.net> <87zhxh98ut.fsf@sergiodj.net> Xref: csiph.com linux.debian.maint.python:10831 linux.debian.devel.mentors:41591 --00000000000046bc050573fb30a5 Content-Type: text/plain; charset="UTF-8" Hello Sergio, No problem. However, the "License:" still doesn't reflect the license > of the software. According to LICENSE: > > We provide this software under a slightly modified version of the > Apache Software License. The only changes to the document were the > replacement of "Apache" with "Pcapy" and "Apache Software Foundation" > with "CORE Security Technologies". Feel free to compare the resulting > document to the official Apache license. > > The `Apache Software License' is an Open Source Initiative Approved > License. > > Therefore, I think a better value for the field would be: > > License: Apache with Pcapy modifications > Ready! > Also, please remove the "All rights reserved." text here: > > Copyright (C) 2003-2011 CORE Security Technologies . > > All rights reserved. > Ready! > Oh, and please fix the years. Nowhere in the code I see "2003-2011". > Doing a basic grep, I see that the year should be 2014. > Ready > > I see that the contributions under the debian/ directory are released > under GPL-3+. That's absolutely fine (I am a GPL advocate as well). > However, I must warn you that the Debian patches will also be released > under this license, which may be problematic if/when you decide to > upstream them. But I understand this is the current situation anyway. > You may want to try to contact Arnaud Fontaine and ask him if he's OK > with changing the license to Apache in the future. > Ok. I will contact Arnaud Fontaine to ask about it. I think it's ok for now. In the next release of package I can update this field. Thanks, but what you did is incomplete. In order to create a new > package, you have to create an entry for it on d/control. What you did > (add ${python3:Depends} to python-pcapy's Depends) is wrong because > you're basically pulling Python 3 dependencies for a Python 2 package. > Please have a look at other packages under them DPMT and check their > d/control; you will find many examples of how to create Python 3 > packages. > Ready! Thanks for your help! Regards! -- Arias Emmanuel https://www.linkedin.com/in/emmanuel-arias-437a6a8a http://eamanu.com --00000000000046bc050573fb30a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Sergio,



No problem.=C2=A0 However, the "License:" still doesn't refle= ct the license
of the software.=C2=A0 According to LICENSE:

=C2=A0 We provide this software under a slightly modified version of the =C2=A0 Apache Software License. The only changes to the document were the =C2=A0 replacement of "Apache" with "Pcapy" and "A= pache Software Foundation"
=C2=A0 with "CORE Security Technologies". Feel free to compare th= e resulting
=C2=A0 document to the official Apache license.

=C2=A0 The `Apache Software License' is an Open Source Initiative Appro= ved
=C2=A0 License.

Therefore, I think a better value for the field would be:

=C2=A0 License: Apache with Pcapy modifications

Ready!


Also, please remove the "All rights reserved." text here:

=C2=A0 Copyright (C) 2003-2011 CORE Security Technologies <oss@coresecurity.com>. =
=C2=A0 =C2=A0All rights reserved.

Ready= !=C2=A0


Oh, and please fix the years.=C2=A0 Nowhere in the code I see "2003-20= 11".
Doing a basic grep, I see that the year should be 2014.

Ready

I see that the contributions under the debian/ directory are released
under GPL-3+.=C2=A0 That's absolutely fine (I am a GPL advocate as well= ).
However, I must warn you that the Debian patches will also be released
under this license, which may be problematic if/when you decide to
upstream them.=C2=A0 But I understand this is the current situation anyway.=
You may want to try to contact Arnaud Fontaine and ask him if he's OK with changing the license to Apache in the future.
Ok. I will contact Arnaud Fontaine to ask about it. I think it&= #39;s ok for now. In the next release of package I can update this field. <= br>

Thanks, but what you did is incomplete.=C2=A0 In order to create a new
package, you have to create an entry for it on d/control.=C2=A0 What you di= d
(add ${python3:Depends} to python-pcapy's Depends) is wrong because
you're basically pulling Python 3 dependencies for a Python 2 package.<= br> Please have a look at other packages under them DPMT and check their
d/control; you will find many examples of how to create Python 3
packages.

Ready!

Thanks for your help!
Regards!=C2=A0

--
http://eamanu.com
--00000000000046bc050573fb30a5--