Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod From: Sergio Durigan Junior Newsgroups: linux.debian.maint.python,linux.debian.devel.mentors Subject: Re: RFS: pcapy/0.11.3-1 [ITA] Date: Mon, 20 Aug 2018 02:40:01 +0200 Message-ID: References: X-Original-To: eamanu15 X-Mailbox-Line: From debian-python-request@lists.debian.org Mon Aug 20 00:31:59 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-12.179 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, LDO_WHITELIST=-5, MENTORSRFS=-0.3, MURPHY_DRUGS_REL8=0.02, PGPSIGNATURE=-5] autolearn=ham autolearn_force=no X-Policyd-Weight: DYN_NJABL=SKIP(0) NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_FROM_MX=-3.1; rate: -6.1 X-URL: http://blog.sergiodj.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailing-List: archive/latest/16231 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/87zhxh98ut.fsf@sergiodj.net Approved: robomod@news.nic.it Lines: 146 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python , "python-modules-team\@lists.alioth.debian.org" , Debian Mentors List X-Original-Date: Sun, 19 Aug 2018 20:31:38 -0400 X-Original-Message-ID: <87zhxh98ut.fsf@sergiodj.net> X-Original-References: <87k1qywmgp.fsf@debian.org> <87bma9a1g5.fsf@sergiodj.net> Xref: csiph.com linux.debian.maint.python:10811 linux.debian.devel.mentors:41587 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Saturday, August 11 2018, eamanu wrote: > Hello Sergio! > > Thanks for your comments! No problem, and sorry for the delay. > 1) On d/copyright, the license specified for the project is wrong. >> According to the LICENSE file, the project is released under a slightly >> modified version of the Apache license. This is something really >> important to get right, otherwise the ftp-masters will certainly reject >> the package. You listed the license as being "GPL-2", but the text is >> clearly not GPL-2. >> >> Ohh!!! Sorry I saw the old d/copyright file to do this. No problem. However, the "License:" still doesn't reflect the license of the software. According to LICENSE: We provide this software under a slightly modified version of the Apache Software License. The only changes to the document were the replacement of "Apache" with "Pcapy" and "Apache Software Foundation" with "CORE Security Technologies". Feel free to compare the resulting document to the official Apache license. The `Apache Software License' is an Open Source Initiative Approved License. Therefore, I think a better value for the field would be: License: Apache with Pcapy modifications Also, please remove the "All rights reserved." text here: Copyright (C) 2003-2011 CORE Security Technologies = .=20 All rights reserved. Oh, and please fix the years. Nowhere in the code I see "2003-2011". Doing a basic grep, I see that the year should be 2014. > 2) Still on d/copyright: as said above, the GPL-2 license is wrong. >> However, I think it's also important to mention that the license text is >> formatted in a strange/wrong manner. You have text like this: >> >> [...] >> Redistribution and use in source and binary forms, with or without >> modification, are permitted provided that the following conditions >> are met: >> >> 1. Redistributions of source code must retain the above >> [...] >> >> The correct format for d/copyright is to indent the text using 1 space, >> and to use . (dot) for blank lines. Like this: >> >> [...] >> Redistribution and use in source and binary forms, with or without >> modification, are permitted provided that the following conditions >> are met: >> . >> 1. Redistributions of source code must retain the above >> [...] >> > > > Ready! Thanks. I see that the contributions under the debian/ directory are released under GPL-3+. That's absolutely fine (I am a GPL advocate as well). However, I must warn you that the Debian patches will also be released under this license, which may be problematic if/when you decide to upstream them. But I understand this is the current situation anyway. You may want to try to contact Arnaud Fontaine and ask him if he's OK with changing the license to Apache in the future. >> >> 3) The package uses a *really* old version of debhelper (version 5!). >> We're at version 11 already, so you should update both d/compat and >> d/control (i.e., depend on debhelp >=3D 11) to reflect that. >> > > Ready! Thanks. >> >> 4) You haven't addressed my comment about building a Python 3 package. >> IMO you should really do that; lintian will warn you if you don't. >> > > Yes, I forgot do that! Sorry! Thanks, but what you did is incomplete. In order to create a new package, you have to create an entry for it on d/control. What you did (add ${python3:Depends} to python-pcapy's Depends) is wrong because you're basically pulling Python 3 dependencies for a Python 2 package. Please have a look at other packages under them DPMT and check their d/control; you will find many examples of how to create Python 3 packages. >> >> 5) You haven't answered my question about why the package has "Suggests: >> doc-base". It seems to be a relic from this very old debhelper; I think >> you can safely remove it. >> > > Yes, I remove it. Since I do not have much knowledge about doc-base and w= hy > it is there, I left it. But now is removed. Thanks, =2D-=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEI3pUsQKHKL8A7zH00Ot2KGX8XjYFAlt6C+oACgkQ0Ot2KGX8 XjZl0g//cOpkzAwoBCX5CHmOrjTeUO4FMXXYjIDbKlxjbKwZwKvoBY1Kds6QwvbW Voos/V235oC4wW3/fHG2rxgI7cXUBqt+W8tjhxWIFgzG5+GpXTUUNM3jRtMH8jlc UCrORynzEkU8v9TiBbdogAeBt7PM8OHqjTOSCpQ6wpo4ihvntfn4xwFWcgKanghz z75B7tFAvSbm6w0us3GFjQ9itdI7hpAv1MbU0FutPIQzTOyqRYSvlcsdPm9qPXi1 8bKy/y1Vs1d9WWEi3uylLy3uGjjmpluLwcFKo3YPICpZprNLbyLc4X9b6sB7HP+T ROfkXMNdAYV3UPuJYJYlnVcV3j2HGIadbrdRcuRpRhqoxItNzZDRlI4aV9PWiYyd ZtklQLwL1f57OKfZKVt8rFzrJUQP/F6COMMrRJF8v19W/1g6jLmtj6gf0hLVdG52 Vo1ElqekytKu7FSDlQNZkI91OeRUf3rzBbpYoCw6iA0GiKYRxzE5OYTfdxk8e49+ jWIxNawzl9rNvMKQyctLPzMVkMnvGMmYevrSxwpHb+5PdCl/gR+Da5YU5FM9kPtK VeYdse14xh8L+VemKP6yVGK6DuN/OOI0yowQX1KttgA5FeyXjiNx2cCyHAr2r9Wz Oo9D6g8e72u6716DQp/R90SiIyFyXO2GOd8FNzc6XrxiLmDX0Ck= =C1ki -----END PGP SIGNATURE----- --=-=-=--