Path: csiph.com!aioe.org!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod From: eamanu15 Newsgroups: linux.debian.maint.python,linux.debian.devel.mentors Subject: Re: RFS: pcapy/0.11.3-1 [ITA] Date: Sat, 11 Aug 2018 05:30:02 +0200 Message-ID: References: X-Mailbox-Line: From debian-python-request@lists.debian.org Sat Aug 11 03:23:35 2018 Old-Return-Path: X-Amavis-Spam-Status: No, score=-1.049 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DIGITS_LETTERS=1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, EMPTY_BODY=3, FOURLA=0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=2, LDO_WHITELIST=-5, MENTORSRFS=-0.3] autolearn=no autolearn_force=no X-Policyd-Weight: DYN_NJABL=ERR(0) NOT_IN_SBL_XBL_SPAMHAUS=-1.5 BL_NJABL=ERR(-1.5) CL_IP_EQ_HELO_IP=-2 (check from: .gmail. - helo: .mail-ua1-x944.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -7 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C46FUK6P9qgsg+7CwNMlZUSdLtZsZBmwPL6wH9a7EnU=; b=MO0j8m6N1do9HjbBjUfI9SkxwuN7a7dSMRjlRN/8vD+HI8RA1YQ2R6CZD1L/Zurjt0 BBDn5bt1jgvYa8IPc40JVK4RPcWymbpeV9tVsHYYFTEJJC1It2TpNuF3hHsqEPyDGVOu NOOw+8GMLH+GADEvJdEz8kHCKTomDGSvtpXEC5otGnYnk36NvvJBuwXZIpVJ2f1ALkw5 ieb7Y2vU+nxI6wSly6gNNhlkBm/9cvF3l3zShrlGTdr5Pw264vLEB/vEwMJzq2LpTmPc 66Ox4MF6lDbMAZV2sjrku3a0lqkTfZLWKDAZEhxxonyOeP2W3Fq1DVy+si+FIZ4YJmAM 4raw== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C46FUK6P9qgsg+7CwNMlZUSdLtZsZBmwPL6wH9a7EnU=; b=YIkLTnEXzh868tb4VwbFNI+SSw8Y9StVJKppwkWWlGbEviH70FG2DunpuawFaGx0A6 MO8fxIIY2QyEw7OgxKh6CAi/O4yfNk5KwLvHnOS0RrKpc2VoZMDdSa+IDhGWab8yClRa xPhGgYzfimsv6YyErT32K+X+PB23igKuMVBZJ2sZFqJ3LAxEvF0beNx7yQTszSBldgQ7 Iij/EcgnUlurNKwKkIjgw/rH/GUSmuoNqaymj8C3mpvZ+68Md2moHOXvVYlvXiUTEhnQ CWRzViFsq9auC1VXjd/SSfbNFUEaO9EgwrJJ15VXTB6lZ7hi/aky8gT0d75HLc3LbAgC aeWA== X-Gm-Message-State: AOUpUlGnYACS2fEoq6IMVTlnZr/F6CsSn4XbCUASrJkwlL22qTQ7UurY cH65wQVrZd5jrZhRFra9495D7rSlNJJjMPlTxykmoQ== X-Google-SMTP-Source: AA+uWPzD8Z7s+DBLDG4t5akTA16tXy3tytc+GxUVcNg27h/de6CIcuefft2ZrrUYB7ZGDQlpxcvsBsAnjpi7WpLoy1g= X-Received: by 2002:a9f:28a4:: with SMTP id d33-v6mr6075504uad.11.1533957783059; Fri, 10 Aug 2018 20:23:03 -0700 (PDT) MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c281c30573206048" X-Mailing-List: archive/latest/16205 List-ID: List-URL: List-Archive: https://lists.debian.org/msgid-search/CACttXDOsWpMUckX-wquTumvMRZdEvUspPB5iw+M77nSRkmcacg@mail.gmail.com Approved: robomod@news.nic.it Lines: 362 Organization: linux.* mail to news gateway Sender: robomod@news.nic.it X-Original-Cc: debian-python , "python-modules-team@lists.alioth.debian.org" , Debian Mentors List X-Original-Date: Sat, 11 Aug 2018 00:22:50 -0300 X-Original-Message-ID: X-Original-References: <87k1qywmgp.fsf@debian.org> Xref: csiph.com linux.debian.maint.python:10785 linux.debian.devel.mentors:41550 --000000000000c281c30573206048 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Sergio, I am really sorry for the delay. I finish the update of pcapy package. I push the commit, but is on UNRELEASED status. Please, check if whole the things are ok, and then I will make change to unstable status on d/changelog Thanks! Regards! El lun., 2 de jul. de 2018 a la(s) 21:36, eamanu15 < emmanuelarias30@gmail.com> escribi=C3=B3: > Hello Sergio, > > Sorry for the delay in my response. > > In this week I will work on your reviews. When I fix the problems I will > push to salsa and will let it know you. > > Thanks! > Regards! > Emmanuel > > El s=C3=A1b., 16 de jun. de 2018 a la(s) 16:38, Sergio Durigan Junior < > sergiodj@debian.org> escribi=C3=B3: > >> Control: owner -1 ! >> Control: tags -1 + moreinfo >> >> On Thursday, June 07 2018, eamanu wrote: >> >> > Dear mentors, >> > >> > I am looking for a sponsor for my package "pcapy" >> > >> > * Package name : pcapy >> > Version : 0.11.3-1 >> > Upstream Author : Core Security >> > * URL : https://github.com/CoreSecurity/pcapy >> > * License : Apache Software License >> > Section : python >> > >> > It builds those binary packages: >> > >> > python-pcapy - Python interface to the libpcap packet capture library >> > >> > To access further information about this package, please visit the >> > following URL: >> > >> > https://mentors.debian.net/package/pcapy >> > >> > >> > Alternatively, one can download the package with dget using this >> command: >> > >> > dget -x >> > https://mentors.debian.net/debian/pool/main/p/pcapy/pcapy_0.11.3-1.dsc >> > >> > More information about hello can be obtained from >> https://www.example.com. >> > >> > Changes since the last upload: >> > >> > [ Jakub Wilk ] >> > * Use canonical URIs for Vcs-* fields. >> > >> > [ Ond=C5=99ej Nov=C3=BD ] >> > * Fixed VCS URL (https) >> > * d/control: Set Vcs-* to salsa.debian.org >> > * d/changelog: Remove trailing whitespaces >> > * Remove debian/pycompat, it's not used by any modern Python helper >> > >> > [ Emmanuel Arias ] >> > * new upstream version >> > * update d/watch to download correctly the last upstream version >> > * update d/control to add Maintainer the DPMT >> > * update d/control to add me to Uploaders field (Closes: #895787) >> > * update debhelper on d/contorl from 5.0.37.2 to 11 >> > * update Standards-Version from 3.9.2 to 4.1.4 on d/control >> > * add Testsuite: autopkgtest-pkg-python on d/control >> > * update d/compat from 5 to 11 >> > * add to copyright file the debian files copyright >> >> Hi Emmanuel, >> >> Thanks for the package, and for your interest in adopting it! The first >> question I have is about the VCS. I tried finding your commits on the >> official Salsa repo, but wasn't able to. Are you using any other >> repository for that? It's much easier to review the changes when >> there's a repository, and I strongly suggest you use the official one >> for the packaging. >> >> As for the review, here's what I'd like you to address: >> >> 1) d/copyright should follow DEP-5. Take a look at: >> >> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ >> >> and you'll be able to find instructions on the format of the file. It >> shouldn't be too hard for you to convert the existing file. >> >> 2) The package doesn't need CDBS anymore, so you can safely remove it >> from the Build-Depends line. >> >> 3) The "Homepage" field can have a better URL: >> >> https://www.coresecurity.com/corelabs-research/open-source-tools/pcapy >> >> 4) You should consider packaging a Python 3 package, as well as the >> Python 2 you're already packaging (in which case you could probably >> split the documentation part into its own package). If Python 3 is not >> supported, you should contact upstream and probably file a bug against >> it. >> >> 5) Any reason why the package has "Suggests: doc-base"? >> >> 6) It's a good habit to export the PYBUILD_NAME variable (on d/rules): >> >> export PYBUILD_NAME=3Dpcapy >> >> This variable tells pybuild what's the name of your project. >> >> 7) It's a good idea to use (on d/rules): >> >> export DEB_BUILD_MAINT_OPTIONS =3D hardening=3D+all >> >> since your package is building a shlib. >> >> 8) The package is installing the LICENSE file by default, but this is >> not needed since we have the d/copyright file. Therefore, it'd be good >> if you could remove this file from the package. You can do that by >> e.g. overriding dh_auto_install and rm'ing the file there. >> >> >> I think that's basically everything I've spotted. Please let me know if >> you need any help. >> >> Cheers, >> >> -- >> Sergio >> GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 >> Please send encrypted e-mail if possible >> http://sergiodj.net/ >> > -- > Arias Emmanuel > https://www.linkedin.com/in/emmanuel-arias-437a6a8a > http://eamanu.com > --=20 Arias Emmanuel https://www.linkedin.com/in/emmanuel-arias-437a6a8a http://eamanu.com --000000000000c281c30573206048 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Sergio,

I am real= ly sorry for the delay.

I finish the update o= f pcapy package. I push the commit, but is on UNRELEASED status.
=

Please, check if whole the things are ok, and then I wi= ll make change to unstable status on d/changelog

T= hanks!
Regards!

El lun., 2 de jul. de 2018 a la(s) 21:36, eamanu15 <emmanuelarias30@gmail.com> es= cribi=C3=B3:
= Hello Sergio,

Sorry= for the delay in my response.

In this week I= will work on your reviews. When I fix the problems I will push to salsa an= d will let it know you.

Thanks!
Regards!
= Emmanuel

El s=C3=A1b., 16 de jun. de 2018 a la(= s) 16:38, Sergio Durigan Junior <sergiodj@debian.org> escribi=C3=B3:
Control: owner -1 !
Control: tags -1 + moreinfo

On Thursday, June 07 2018, eamanu wrote:

> Dear mentors,
>
> I am looking for a sponsor for my package "pcapy"
>
> * Package name=C2=A0 =C2=A0 : pcapy
> Version=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: 0.11.3-1
> Upstream Author : Core Security <oss@coresecurity.com>
> * URL=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: htt= ps://github.com/CoreSecurity/pcapy
> * License=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: Apache Software License > Section=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: python
>
> It builds those binary packages:
>
> python-pcapy - Python interface to the libpcap packet capture library<= br> >
> To access further information about this package, please visit the
> following URL:
>
> https://mentors.debian.net/package/pcapy
>
>
> Alternatively, one can download the package with dget using this comma= nd:
>
> dget -x
> https://mentors.debian.ne= t/debian/pool/main/p/pcapy/pcapy_0.11.3-1.dsc
>
> More information about hello can be obtained from https://www.example.co= m.
>
> Changes since the last upload:
>
> [ Jakub Wilk ]
> * Use canonical URIs for Vcs-* fields.
>
> [ Ond=C5=99ej Nov=C3=BD ]
> * Fixed VCS URL (https)
> * d/control: Set Vcs-* to salsa.debian.org
> * d/changelog: Remove trailing whitespaces
> * Remove debian/pycompat, it's not used by any modern Python helpe= r
>
> [ Emmanuel Arias ]
> * new upstream version
> * update d/watch to download correctly the last upstream version
> * update d/control to add Maintainer the DPMT
> * update d/control to add me to Uploaders field (Closes: #895787)
> * update debhelper on d/contorl from 5.0.37.2 to 11
> * update Standards-Version from 3.9.2 to 4.1.4 on d/control
> * add Testsuite: autopkgtest-pkg-python on d/control
> * update d/compat from 5 to 11
> * add to copyright file the debian files copyright

Hi Emmanuel,

Thanks for the package, and for your interest in adopting it!=C2=A0 The fir= st
question I have is about the VCS.=C2=A0 I tried finding your commits on the=
official Salsa repo, but wasn't able to.=C2=A0 Are you using any other<= br> repository for that?=C2=A0 It's much easier to review the changes when<= br> there's a repository, and I strongly suggest you use the official one for the packaging.

As for the review, here's what I'd like you to address:

1) d/copyright should follow DEP-5.=C2=A0 Take a look at:

=C2=A0 https://www.debian.org/doc/= packaging-manuals/copyright-format/1.0/

and you'll be able to find instructions on the format of the file.=C2= =A0 It
shouldn't be too hard for you to convert the existing file.

2) The package doesn't need CDBS anymore, so you can safely remove it from the Build-Depends line.

3) The "Homepage" field can have a better URL:

=C2=A0 https://www.coresecurit= y.com/corelabs-research/open-source-tools/pcapy

4) You should consider packaging a Python 3 package, as well as the
Python 2 you're already packaging (in which case you could probably
split the documentation part into its own package).=C2=A0 If Python 3 is no= t
supported, you should contact upstream and probably file a bug against
it.

5) Any reason why the package has "Suggests: doc-base"?

6) It's a good habit to export the PYBUILD_NAME variable (on d/rules):<= br>
=C2=A0 export PYBUILD_NAME=3Dpcapy

This variable tells pybuild what's the name of your project.

7) It's a good idea to use (on d/rules):

=C2=A0 export DEB_BUILD_MAINT_OPTIONS =3D hardening=3D+all

since your package is building a shlib.

8) The package is installing the LICENSE file by default, but this is
not needed since we have the d/copyright file.=C2=A0 Therefore, it'd be= good
if you could remove this file from the package.=C2=A0 You can do that by e.g. overriding dh_auto_install and rm'ing the file there.


I think that's basically everything I've spotted.=C2=A0 Please let = me know if
you need any help.

Cheers,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF=C2=A0 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http:= //sergiodj.net/
--
--
http://eamanu.com
--000000000000c281c30573206048--